Sign main branch container builds with cosign #194
Merged
+21
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
=====================================
Coverage 7.04% 7.04%
=====================================
Files 49 49
Lines 1818 1818
Branches 99 99
=====================================
Hits 128 128
Misses 1685 1685
Partials 5 5 ☔ View full report in Codecov by Sentry. |
|
Fixed Issues
|
withinfocus
commented
Dec 13, 2024
| @@ -41,6 +41,9 @@ jobs: | |||
| name: Build Docker images | |||
| runs-on: ubuntu-22.04 | |||
| needs: build-artifacts | |||
| permissions: | |||
| security-events: write | |||
There was a problem hiding this comment.
ℹ️ This was missed previously so I added it, to keep the token scoped.
mzieniukbw
approved these changes
Dec 14, 2024
Eeebru
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/VULN-130
📔 Objective
Signs container images built off
mainwith Cosign. This uses Sigstore's in-house certificate authority with short-lived keys that are all self-managed with the tool, which will also utilize GitHub's provided OIDC entity. As part of an effort to increase transparency of what we build as an open source company, these signatures are also sent to Rekor -- users of our images are then free to verify the images against that log.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes