[PM-7963] Fix vault timeout immediately on Android Fido2 autofill #3234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Fix vault timeout immediately on Android Fido2 autofill, where it was locking immediately after user unlocks because changing activity
Code changes
NoHistory
tofalse
so we can launch theMainActivity
and return to this one. Added the activity launcher so we can launchMainActivity
to unlock the vault after the user selects the cipher to autofill which confirms unlock on the callback._unlockVaultTcs
so we can await until the user unlocks on immediate timeout vaults to ensure vault is unlocked for the Fido2 flow.CredentialProviderConstants.Fido2CredentialNeedsUnlockingAgainBecauseImmediateTimeout
to have a way to know after unlocking that is because of this scenario and then set the result back. Here a caveat is that we setvaultTimeoutService.DelayLockAndLogoutMs
in order to maintain a time window of the vault unlocked for this flow. Otherwise it'll be immediately locked after theMainActivity
is finished.Before you submit
dotnet format --verify-no-changes
) (required)