Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-9020] Fix production server URLs to use the correct ones #3303

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[PM-9020] Fix production server URLs to use the correct ones #3303

wants to merge 1 commit into from
+1 −1

Conversation

fedemkr
Copy link
Member

@fedemkr fedemkr commented Jun 19, 2024

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

US and EU production servers should not be using base url + api or identity suffixes, only SelfHosted ones.

Code changes

  • ApiService: Add a constrain when setting urls to use the logic of BaseUrl + Suffix only when in SelfHosted region.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@fedemkr fedemkr changed the title [PM-9020] Fix SetUrls in ApiService to only add the suffix on SelfHosted [PM-9020] Fix production server URLs to use the correct ones Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fedemkr