Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore upgrading dotnet-sdk #158

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

jonashendrickx
Copy link
Member

No description provided.

@jonashendrickx jonashendrickx requested a review from a team as a code owner September 30, 2024 12:04
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.79%. Comparing base (1d5d490) to head (8682d06).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #158   +/-   ##
=======================================
  Coverage   59.79%   59.79%           
=======================================
  Files          43       43           
  Lines         689      689           
  Branches       56       56           
=======================================
  Hits          412      412           
  Misses        273      273           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonashendrickx jonashendrickx enabled auto-merge (squash) September 30, 2024 14:10
@abergs
Copy link
Member

abergs commented Sep 30, 2024

@jonashendrickx This PR needs some additional context & motivation before approval.

@jonashendrickx
Copy link
Member Author

@jonashendrickx This PR needs some additional context & motivation before approval.

I'm matching the Bitwarden configuration. We should only update it if there's a vulnerability or bug. By upgrading it everyone is forced to use that specific sdk version .

@jonashendrickx jonashendrickx merged commit ef67309 into main Oct 1, 2024
7 checks passed
@jonashendrickx jonashendrickx deleted the renovate/ignore-dotnet-sdk branch October 1, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants