Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GHATL for test reports #21

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Use GHATL for test reports #21

merged 4 commits into from
Sep 19, 2023

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Sep 19, 2023

Adds GHATL for reporting test results.

I left in dorny/test-reporter as well, but it might be obsolete now. Let me know if you want me to keep it or remove it.

Removed it

@Tyrrrz Tyrrrz added the enhancement New feature or request label Sep 19, 2023
@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented Sep 19, 2023

Preview: https://github.com/passwordless/passwordless-dotnet/actions/runs/6235450258 (all tests are skipped at the moment)

image

Copy link
Member

@justindbaur justindbaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it a lot, not sure if we trust the author of it though 😄. I like that it is shown on the summary vs in a separate stage. It doesn't matter as much in this workflow because there aren't that many stages but it would make a world of difference in bitwarden/server.

The only downside is we can't use this for bitwarden/clients but since these are pretty displays meant for human consumption the fact that they use different formats is fine.

@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented Sep 19, 2023

I like that it is shown on the summary vs in a separate stage.

It also doesn't require any extra workflow steps :)

Do you think I should remove dorny/test-reporter or keep both for now?

@justindbaur
Copy link
Member

@Tyrrrz I say we remove it.

@Tyrrrz Tyrrrz merged commit 5d6bc7d into main Sep 19, 2023
@Tyrrrz Tyrrrz deleted the use-ghatl branch September 19, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants