Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package metadata, sourcelink, inline docs, debug symbols, enable reproducible builds #32

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Add package metadata, sourcelink, inline docs, debug symbols, enable reproducible builds #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4819eb
Add package metadata, sourcelink, inline docs, debug symbols, enable …
Tyrrrz Sep 20, 2023
de6b10f
Re-enable implicit usings
Tyrrrz Sep 20, 2023
7cff977
Set CI build globally
Tyrrrz Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ indent_style = space
[*.xml]
indent_size = 2

# Props/targets/Csproj/fsproj/vbproj files
[*.{props,targets,csproj,fsproj,vbproj}]
indent_size = 2

# C# files
[*.cs]

Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,7 @@ jobs:
dotnet pack
--no-build
--configuration Release
--version-suffix "ci-${{ env.CLEAN_BRANCH_NAME }}-${{ github.run_id }}"
env:
CLEAN_BRANCH_NAME: ${{needs.build-dotnet.outputs.clean_name}}
--version-suffix "ci-${{ needs.build-dotnet.outputs.clean_name }}-${{ github.run_id }}"
- name: Publish NuGet Packages
run: >
Expand Down
11 changes: 9 additions & 2 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,19 @@
<Project>
<!-- See https://aka.ms/dotnet/msbuild/customize for more details on customizing your build -->

<PropertyGroup>
<CurrentPreviewTfm>net8.0</CurrentPreviewTfm>
<!--<IncludePreview>true</IncludePreview>-->
<IncludePreview Condition="'$(IncludePreview)' == ''">false</IncludePreview>
<ContinuousIntegrationBuild Condition="'$(CI)' == 'true'">true</ContinuousIntegrationBuild>
abergs marked this conversation as resolved.
Show resolved Hide resolved
</PropertyGroup>

<PropertyGroup>
<LangVersion>latest</LangVersion>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<WarningsAsErrors>nullable</WarningsAsErrors>
<CheckEolTargetFramework>false</CheckEolTargetFramework>
<IsPackable>false</IsPackable>
</PropertyGroup>

<PropertyGroup>
Expand All @@ -25,4 +31,5 @@
-->
<Using Remove="System.Net.Http" />
</ItemGroup>

</Project>
13 changes: 11 additions & 2 deletions src/Passwordless/Passwordless.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,23 @@
<PropertyGroup>
<TargetFrameworks>net462;net6.0;net7.0;netstandard2.0</TargetFrameworks>
<TargetFrameworks Condition="'$(IncludePreview)' == 'true'">$(TargetFrameworks);$(CurrentPreviewTfm)</TargetFrameworks>
<IsPackable>true</IsPackable>
<PublishAot Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp' AND $([MSBuild]::VersionGreaterThanOrEquals($(TargetFrameworkVersion), '8.0'))">true</PublishAot>
</PropertyGroup>

<!-- Packaging-related properties -->
<PropertyGroup>
<Authors>Bitwarden</Authors>
<RepositoryUrl>https://github.com/passwordless/passwordless-dotnet</RepositoryUrl>
<RepositoryType>git</RepositoryType>
<Description>The official Bitwarden Passwordless.dev .NET library</Description>
<PackageProjectUrl>https://github.com/passwordless/passwordless-dotnet</PackageProjectUrl>
<PackageReleaseNotes>https://github.com/passwordless/passwordless-dotnet/releases</PackageReleaseNotes>
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
<PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
<PackageReadmeFile>README.md</PackageReadmeFile>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<DebugType>embedded</DebugType>
</PropertyGroup>

<!-- .NET 6 first introduced these types, for all others we include our own pollyfill so that it builds -->
Expand All @@ -22,6 +30,7 @@
<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Http" Version="7.0.0" />
<PackageReference Include="Microsoft.Extensions.Options" Version="7.0.1" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="all" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'net462'">
Expand Down
Loading