PAS179: Migrate ASP.NET Identity example #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyrrrz
reviewed
Sep 29, 2023
| @@ -29,6 +29,8 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "examples", "examples", "{6E | |||
| EndProject | |||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Passwordless.Example", "examples\Passwordless.Example\Passwordless.Example.csproj", "{15D70E7A-D222-4C60-93B2-06570A2BE5F2}" | |||
| EndProject | |||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Passwordless.AspNetIdentity.Example", "examples\Passwordless.AspNetIdentity.Example\Passwordless.AspNetIdentity.Example.csproj", "{F9487727-715D-442F-BE2F-7FB9931606C2}" | |||
There was a problem hiding this comment.
Maybe we should call the project .AspNetCore. to match the naming convention we adopted in the SDK? Or should we try to move away from that?
| @@ -29,6 +29,8 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "examples", "examples", "{6E | |||
| EndProject | |||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Passwordless.Example", "examples\Passwordless.Example\Passwordless.Example.csproj", "{15D70E7A-D222-4C60-93B2-06570A2BE5F2}" | |||
| EndProject | |||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Passwordless.AspNetIdentity.Example", "examples\Passwordless.AspNetIdentity.Example\Passwordless.AspNetIdentity.Example.csproj", "{F9487727-715D-442F-BE2F-7FB9931606C2}" | |||
There was a problem hiding this comment.
In any case, I would maybe rename the project to put Example part first: Passwordless.Example.AspNetIdentity.
| @@ -0,0 +1,11 @@ | |||
| using Microsoft.Extensions.DependencyInjection; | |||
|
|
|||
| namespace Passwordless.DataContext; | |||
There was a problem hiding this comment.
Can we update the namespaces so they match the project name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.