Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAS-207: XML Comments #55

Merged
merged 9 commits into from
Oct 27, 2023
Merged

PAS-207: XML Comments #55

merged 9 commits into from
Oct 27, 2023

Conversation

jrmccannon
Copy link
Contributor

@jrmccannon jrmccannon commented Oct 6, 2023 •
edited by Tyrrrz
Loading

Closes #35

@jrmccannon jrmccannon linked an issue Oct 6, 2023 that may be closed by this pull request
Provide full inline documentation and fix warnings #35
Closed
@jrmccannon jrmccannon requested a review from abergs October 9, 2023 17:14
@Tyrrrz
Copy link
Contributor

Tyrrrz commented Oct 11, 2023 •
edited
Loading

Updated the PR description to link it to #35

Also created corresponding JIRA item: https://bitwarden.atlassian.net/browse/PAS-207

@Tyrrrz Tyrrrz changed the title XML Comments PAS-207: XML Comments Oct 11, 2023
@Tyrrrz
Copy link
Contributor

Tyrrrz commented Oct 23, 2023

Can this be reviewed or is there more to come?

@jrmccannon jrmccannon marked this pull request as ready for review October 27, 2023 13:29
abergs
abergs reviewed Oct 27, 2023
View reviewed changes
Copy link
Member

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some small nitpicks, otherwise it looks good :)

After those are adressed we're good to go.

src/Passwordless/Models/Credential.cs Show resolved Hide resolved
src/Passwordless/Models/Credential.cs Outdated Show resolved Hide resolved
src/Passwordless/Models/Credential.cs Outdated Show resolved Hide resolved
@jrmccannon jrmccannon merged commit d4890a1 into main Oct 27, 2023
6 checks passed
@jrmccannon jrmccannon deleted the xml-comments branch October 27, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abergs abergs abergs left review comments

@Tyrrrz Tyrrrz Tyrrrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide full inline documentation and fix warnings
3 participants
@jrmccannon @Tyrrrz @abergs