Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement tests #67

Merged
merged 13 commits into from
Nov 8, 2023
Merged

Implement tests #67

merged 13 commits into from
Nov 8, 2023

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Nov 6, 2023

No description provided.

@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented Nov 6, 2023

@abergs we have to agree on the Docker image distribution strategy to have the tests run on CI.

Related: bitwarden/passwordless-server#175

@Tyrrrz Tyrrrz marked this pull request as ready for review November 8, 2023 15:05
@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented Nov 8, 2023

@abergs Considering that the existing optimistic tests (in main) don't actually work, I propose we merge this PR in the current state, since it's going to be a net positive anyway. I will then be able to iterate by adding tests more freely, since the infra will already be in place (and I won't drag this PR on for a month 😅).

@Tyrrrz Tyrrrz requested review from abergs and jrmccannon November 8, 2023 15:19
@Tyrrrz Tyrrrz merged commit 1c1dbb9 into main Nov 8, 2023
6 checks passed
@Tyrrrz Tyrrrz deleted the tests branch November 8, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abergs abergs Awaiting requested review from abergs

@jrmccannon jrmccannon Awaiting requested review from jrmccannon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Tyrrrz