Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for Passwordless.AspNetCore #83

Merged
merged 16 commits into from
Nov 27, 2023
Merged

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Nov 24, 2023

No description provided.

@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented Nov 24, 2023

For parity with existing tests currently missing:

@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented Nov 24, 2023

@abergs this exceeded my timelimit allocated for finishing up tests. What do you think I should do with it in the current state?

The idea was to use a similar approach to testing Passwordless.AspNetCore as we currently do with Passwordless. It would wrap a dummy ASP.NET Core app with identity and test Passwordless endpoints to make sure they're working correctly (against a dockerized API).

The issue currently is that to reach full test parity, we need #75 and maybe something else. Also, I've uncovered a bug in the SDK in the process. On top of that, one test doesn't work and I'm not entirely sure why.

Currently, these tests are pretty valuable already as they verify a big chunk of the infra we have in Passwordless.AspNetCore, but they don't verify as much of the identity business logic as the previous tests did. Perhaps if we had proper coverage reporting, it would be easier to see the difference.

@Tyrrrz Tyrrrz marked this pull request as ready for review November 27, 2023 15:03
@Tyrrrz Tyrrrz merged commit a11fc99 into main Nov 27, 2023
6 checks passed
@Tyrrrz Tyrrrz deleted the identity-tests branch November 27, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants