Skip to content

Conversation

fntyler
Copy link
Contributor

@fntyler fntyler commented Sep 17, 2025

๐ŸŽŸ๏ธ Tracking

BRE-1158

๐Ÿ“” Objective

Include AppSec team and BRE dept for repository-level ownership of Dockerfile, and Dockerfile related, files.

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@fntyler fntyler marked this pull request as ready for review September 17, 2025 20:13
@fntyler fntyler requested a review from a team as a code owner September 17, 2025 20:13
abergs
abergs previously approved these changes Sep 18, 2025
@fntyler fntyler requested a review from abergs September 30, 2025 00:59
@fntyler fntyler enabled auto-merge (squash) September 30, 2025 00:59
@fntyler fntyler merged commit af666df into main Sep 30, 2025
5 checks passed
@fntyler fntyler deleted the bre/bre-1158/co-dockerfiles branch September 30, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants