Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve SemVer for NVM updates #10

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Preserve SemVer for NVM updates #10

merged 1 commit into from
Jun 25, 2024

Conversation

withinfocus
Copy link
Contributor

@withinfocus withinfocus commented Jun 20, 2024

🎟️ Tracking

Internal change. See bitwarden/contributing-docs#371.

📔 Objective

NVM updates will currently obey :pinAllExceptPeerDependencies given our setup here and its use in Node-oriented repos. To avoid unnecessary upkeep, we can tell Renovate to preserve semantic versioning so this will just end up as v20 for example.

We considered setting global rules on maximum versions for Node and NPM generally, but this should be inside the repos' package.json engines configurations e.g. https://github.com/bitwarden/clients/blob/main/package.json#L226-L229.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@withinfocus withinfocus marked this pull request as ready for review June 20, 2024 14:58
@withinfocus withinfocus requested review from a team as code owners June 20, 2024 14:58
@@ -6,7 +6,6 @@
":separateMajorReleases",
"config:base",
"group:monorepos",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ Found an errant newline.

},
{
"matchManagers": ["nvm"],
"rangeStrategy": "replace"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we lock it down to 20? We don't want to upgrade to other versions atm.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned this in the description -- Renovate wants engines driving this and the constraints aren't recommended by them. I think we can allow certain projects to upgrade more aggressively too and we have some teams willing to manage that themselves.

@withinfocus withinfocus requested a review from Hinton June 24, 2024 18:05
@withinfocus withinfocus merged commit 31277ec into main Jun 25, 2024
1 check passed
@withinfocus withinfocus deleted the nvm branch June 25, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants