Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use-sdk-for-encrypt-decrypt #110

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

MGibson1
Copy link
Member

@MGibson1 MGibson1 commented Jan 8, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15093

📔 Objective

Introduces a namespace for pure SDK functions. This PR is a draft to invite discussion over a good way to handle SDK interfaces with differing levels of state.

Currently, SDKs are bound to a server only or a server and a specific authenticated user on that server. However, no type differences between these level of context exist. This PR introduces a new context, one without any state, so I called it BitwardenPure.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Logo
Checkmarx One – Scan Summary & Details6b27106a-292b-4cb0-bd72-f97ef8939bb5

Great job, no security vulnerabilities found in this Pull Request

@MGibson1
Copy link
Member Author

@dani-garcia would you mind taking a look at this when you have a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant