[PM-13166] Rename Client* to *Client

[tangowithfoxtrot]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13166

📔 Objective

Use more intuitive naming by updating Client<_> to <_>Client.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
  team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
  issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – c4858ee8-e7e9-4aa2-aec0-fc327e9c94fb

No New Or Fixed Issues Found

[codecov]

Codecov Report

Attention: Patch coverage is 18.75000% with 26 lines in your changes missing coverage. Please review.

Project coverage is 64.45%. Comparing base (a89b588) to head (77c3247).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/bitwarden-uniffi/src/lib.rs	0.00%	14 Missing ⚠️
crates/bitwarden-wasm-internal/src/client.rs	0.00%	4 Missing ⚠️
...tes/bitwarden-core/src/platform/platform_client.rs	0.00%	2 Missing ⚠️
crates/bitwarden-exporters/src/exporter_client.rs	0.00%	2 Missing ⚠️
...rates/bitwarden-generators/src/generator_client.rs	0.00%	2 Missing ⚠️
crates/bitwarden-send/src/send_client.rs	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   64.43%   64.45%   +0.02%     
==========================================
  Files         188      188              
  Lines       13832    13832              
==========================================
+ Hits         8912     8915       +3     
+ Misses       4920     4917       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coroiu]

Looking good, thanks for taking this on!

[Hinton]

This will be a breaking change for our clients, would be good to make the mobile team aware of this so they can update.

[coroiu]

Good catch by Oscar! Make sure to let Oscar know when this has been merged so that he can publish the Swift lib.

Btw @tangowithfoxtrot did you test opening and building the test swift project in crates/bitwarden-uniffi/swift/iOS/App.xcodeproj ?

[Hinton]

We also have the android project ...

[tangowithfoxtrot]

@Hinton and @coroiu, I was able to build and run the Android project without needing to change anything in bitwarden/android. However, I haven't been able to get the iOS project to build at all. Is there something beyond what's written in the contributing docs to get it to build?

[Hinton]

The project's we're referencing exists in this repository under https://github.com/bitwarden/sdk-internal/tree/main/crates/bitwarden-uniffi.

[Hinton]

Android seems fine, but the iOS sample has some build errors. (You should update the branch first though since there are 2 errors that are fixed on main now).

[tangowithfoxtrot]

Alright. I merged the updates from main and was able to build the example Swift and Kotlin applications successfully. The Swift app required updating the symbol names, while the Kotlin app did not.