Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path in Android build script #34

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

tangowithfoxtrot
Copy link
Contributor

@tangowithfoxtrot tangowithfoxtrot commented Nov 18, 2024

📔 Objective

When following the Contributing Docs to build the Android app, the build script couldn't find my libbitwarden_uniffi.so file. It seems the path for this changed in #26. This just updates the build script to use the new path.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Nov 18, 2024

Logo
Checkmarx One – Scan Summary & Details9fdc69eb-e0c7-4aff-a4d8-0e5b64daa2ba

Fixed Issues

Severity Issue Source File / Package
MEDIUM Last User Is 'root' /Dockerfile: 44
MEDIUM Unpinned Actions Full Length Commit SHA /release-swift.yml: 73
MEDIUM Unpinned Actions Full Length Commit SHA /build-swift.yml: 95
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 44
MEDIUM Unpinned Actions Full Length Commit SHA /publish-rust-crates.yml: 76
MEDIUM Unpinned Actions Full Length Commit SHA /release-swift.yml: 136
MEDIUM Unpinned Actions Full Length Commit SHA /build-wasm-internal.yml: 91
MEDIUM Unpinned Actions Full Length Commit SHA /publish-wasm-internal.yml: 74
MEDIUM Unpinned Actions Full Length Commit SHA /publish-wasm-internal.yml: 80

@tangowithfoxtrot tangowithfoxtrot marked this pull request as ready for review November 18, 2024 17:15
@tangowithfoxtrot tangowithfoxtrot changed the title Update publish-local.sh Fix path in Android build script Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.87%. Comparing base (1b10d83) to head (71ad4ba).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   62.87%   62.87%           
=======================================
  Files         179      179           
  Lines       12699    12699           
=======================================
  Hits         7985     7985           
  Misses       4714     4714           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tangowithfoxtrot tangowithfoxtrot merged commit 09ad475 into main Nov 29, 2024
40 checks passed
@tangowithfoxtrot tangowithfoxtrot deleted the fix-path-in-kotlin-build-script branch November 29, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants