-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-15096] Add xchacha20-poly1305-blake3-ctx cipher #41
Draft
quexten
wants to merge
17
commits into
main
Choose a base branch
from
km/beeep/chacha20-poly1305-blake3-ctx
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+353
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
+ Coverage 65.27% 65.66% +0.39%
==========================================
Files 180 181 +1
Lines 13833 13993 +160
==========================================
+ Hits 9029 9189 +160
Misses 4804 4804 ☔ View full report in Codecov by Sentry. |
quexten
changed the title
Add chacha20-poly1305-blake3-ctx cipher
Add xchacha20-poly1305-blake3-ctx cipher
Dec 2, 2024
quexten
changed the title
Add xchacha20-poly1305-blake3-ctx cipher
[PM-15096] Add xchacha20-poly1305-blake3-ctx cipher
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15096
📔 Objective
Add a cryptofunction implementation for xchacha20-poly1305. Specifically, in order to prevent attacks making use of the lack of key-comitting, we implement ctx wrapping based on https://eprint.iacr.org/2022/1260.pdf using blake3, which creates a new mac that binds to all inputs (nonce, key, ad, ad tag), and by injectivity, also plaintext/ciphertext.
Note: There is no encstring implementation yet. The idea is for encstrings and for other protocols (IPC in rust?) to make use of this safe primitive.
Note: This is behind a compile-time feature flag for now.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes