-
Notifications
You must be signed in to change notification settings - Fork 17
Duplicate login detection #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewers, if you prefer I squash my commits into a clean single commit, please let me know. |
This is really cool work! Thank you @harr1424. As we take in community prs, we do an evaluation of priority with our project managers. I will surface the ticket (not seeing one generated at the moment), let me get back to you. |
There is no need to squash your commits now, when merging to main we do a squash commit |
🎟️ Tracking
Web app PR
https://github.com/orgs/bitwarden/discussions/15942
https://community.bitwarden.com/t/duplicate-removal-tool-report-including-merge/648
📔 Objective
This pull request is intended to integrate logic for finding duplicate ciphers into the SDK. It is a best effort attempt to directly implement a TypeScript service used in the Web app into the SDK.
Limitations & Divergence from Web app
Host
matching strategy, port numbers present in the URL that match the URL's scheme ( 80 for HTTP, 443 for HTTPS ) will not be considered. This is due to a differences in the npm URL API and the url crate available in Rust. In the future, regular expressions could likely be used here instead.Domain
matching strategy will not support IPv4 or IPv6 addresses, due to limitations in the psl crate. This can also likely be implemented using regular expressions in the future.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes