Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codeowners): update ownership of various github actions #75

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

addisonbeck
Copy link
Contributor

@addisonbeck addisonbeck commented Dec 10, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14840

📔 Objective

Update the ownership of various Github actions such that:

  1. Platform is responsible for build jobs
  2. BRE and Platform are responsible for release jobs
  3. The setup is consistent with the sdk repository: chore(codeowners): update ownership of various github actions sdk-sm#1190

This lines up with the CI/CD Partnership Model initiative.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsfb917b38-2d27-4248-83a8-0fddff50bb2b

No New Or Fixed Issues Found

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.92%. Comparing base (1f343cb) to head (5d528ea).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   63.92%   63.92%           
=======================================
  Files         186      186           
  Lines       12905    12905           
=======================================
  Hits         8249     8249           
  Misses       4656     4656           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@addisonbeck addisonbeck requested review from a team, justindbaur and coroiu and removed request for a team and justindbaur December 10, 2024 19:37
@addisonbeck addisonbeck marked this pull request as ready for review December 10, 2024 20:51
@addisonbeck addisonbeck merged commit 616a77c into main Dec 11, 2024
41 checks passed
@addisonbeck addisonbeck deleted the platform/addison/14840/github-actions-codeowners branch December 11, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants