Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy CI #84

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Fix clippy CI #84

merged 5 commits into from
Dec 16, 2024

Conversation

dani-garcia
Copy link
Member

🎟️ Tracking

📔 Objective

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Dec 16, 2024

Logo
Checkmarx One – Scan Summary & Details39e842cb-e15c-432f-bbc7-de6a689c3d4b

No New Or Fixed Issues Found

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 64.43%. Comparing base (c3053cd) to head (ef9c084).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden-uniffi/src/tool/mod.rs 0.00% 7 Missing ⚠️
crates/bitwarden-uniffi/src/platform/fido2.rs 0.00% 2 Missing ⚠️
crates/bitwarden-wasm-internal/src/client.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   64.43%   64.43%           
=======================================
  Files         188      188           
  Lines       13832    13832           
=======================================
  Hits         8912     8912           
  Misses       4920     4920           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dani-garcia dani-garcia requested a review from Hinton December 16, 2024 13:37
@dani-garcia dani-garcia marked this pull request as ready for review December 16, 2024 13:37
@dani-garcia dani-garcia requested a review from Hinton December 16, 2024 14:00
@dani-garcia dani-garcia merged commit a89b588 into main Dec 16, 2024
39 checks passed
@dani-garcia dani-garcia deleted the ps/fix-clippy-ci branch December 16, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants