[PM-15614] Allow Users to opt out of new device verification · bitwarden/server@5f379c6

Triggered via pull request December 21, 2024 16:57

ike-kottlowski

synchronize #5176

Status Success

Total duration 6m 18s

Artifacts –

scan.yml

on: pull_request_target

Annotations

6 errors and 10 warnings

Bit.Core.Test.AdminConsole.OrganizationFeatures.Organizations.OrganizationSignUp.CloudICloudOrganizationSignUpCommandTests ► SignUp_AssignsOwnerToDefaultCollection(planType: FamiliesAnnually, signup: OrganizationSignup { AdditionalSeats = 46, Additiona...: test/Core.Test/AdminConsole/OrganizationFeatures/Organizations/OrganizationSignUp/CloudOrganizationSignUpCommandTests.cs#L97

Failed test found in: test/Core.Test/TestResults/oss-test-results.trx Error: Assert.NotNull() Failure: Value of type 'Nullable<Guid>' does not have a value

Bit.Core.Test.AdminConsole.OrganizationFeatures.Organizations.OrganizationSignUp.CloudICloudOrganizationSignUpCommandTests ► SignUp_PM_Family_Passes(planType: FamiliesAnnually, signup: OrganizationSignup { AdditionalSeats = 94, AdditionalServiceAccount...: test/Core.Test/AdminConsole/OrganizationFeatures/Organizations/OrganizationSignUp/CloudOrganizationSignUpCommandTests.cs#L47

Failed test found in: test/Core.Test/TestResults/oss-test-results.trx Error: NSubstitute.Exceptions.ReceivedCallsException : Expected to receive exactly 1 call matching: CreateAsync(o => (o.AccessSecretsManager == value(Bit.Core.Test.AdminConsole.OrganizationFeatures.Organizations.OrganizationSignUp.CloudICloudOrganizationSignUpCommandTests+<>c__DisplayClass0_0).signup.UseSecretsManager)) Actually received no matching calls.

Bit.Core.Test.AdminConsole.OrganizationFeatures.Organizations.OrganizationSignUp.CloudICloudOrganizationSignUpCommandTests ► SignUp_SM_Passes(planType: EnterpriseAnnually, signup: OrganizationSignup { AdditionalSeats = 193, AdditionalServiceAccounts = ...: src/Core/AdminConsole/OrganizationFeatures/Organizations/CloudOrganizationSignUpCommand.cs#L59

Failed test found in: test/Core.Test/TestResults/oss-test-results.trx test/Core.Test/TestResults/oss-test-results.trx test/Core.Test/TestResults/oss-test-results.trx test/Core.Test/TestResults/oss-test-results.trx Error: Bit.Core.Exceptions.BadRequestException : Organizations with a Managed Service Provider do not support Secrets Manager.

Bit.Core.Test.AdminConsole.OrganizationFeatures.Organizations.OrganizationSignUp.CloudICloudOrganizationSignUpCommandTests ► SignUpAsync_InvalidateServiceAccount_ShouldThrowException(signup: OrganizationSignup { AdditionalSeats = 113, AdditionalService...: test/Core.Test/AdminConsole/OrganizationFeatures/Organizations/OrganizationSignUp/CloudOrganizationSignUpCommandTests.cs#L236

Failed test found in: test/Core.Test/TestResults/oss-test-results.trx Error: Assert.Contains() Failure: Sub-string not found String: "Organizations with a Managed Service Prov"··· Not found: "You can't subtract Machine Accounts!"

Bit.Core.Test.AdminConsole.OrganizationFeatures.Organizations.OrganizationSignUp.CloudICloudOrganizationSignUpCommandTests ► SignUpAsync_SecretManager_AdditionalServiceAccounts_NotAllowedByPlan_ShouldThrowException(signup: OrganizationSignup { Addition...: test/Core.Test/AdminConsole/OrganizationFeatures/Organizations/OrganizationSignUp/CloudOrganizationSignUpCommandTests.cs#L202

Failed test found in: test/Core.Test/TestResults/oss-test-results.trx Error: Assert.Contains() Failure: Sub-string not found String: "Organizations with a Managed Service Prov"··· Not found: "Plan does not allow additional Machine Ac"···

Bit.Core.Test.AdminConsole.OrganizationFeatures.Organizations.OrganizationSignUp.CloudICloudOrganizationSignUpCommandTests ► SignUpAsync_SMSeatsGreatThanPMSeat_ShouldThrowException(signup: OrganizationSignup { AdditionalSeats = 57, AdditionalServiceAcc...: test/Core.Test/AdminConsole/OrganizationFeatures/Organizations/OrganizationSignUp/CloudOrganizationSignUpCommandTests.cs#L219

Failed test found in: test/Core.Test/TestResults/oss-test-results.trx Error: Assert.Contains() Failure: Sub-string not found String: "Organizations with a Managed Service Prov"··· Not found: "You cannot have more Secrets Manager seat"···

Quality scan: src/Core/Auth/Identity/TokenProviders/DuoUniversalTokenProvider.cs#L23

XML comment has badly formed XML -- 'End tag 'summary' does not match the start tag 'User'.'

Quality scan: src/Core/Auth/Identity/TokenProviders/DuoUniversalTokenProvider.cs#L24

XML comment has badly formed XML -- 'Expected an end tag for element 'User'.'

Quality scan: src/Core/Auth/Identity/TokenProviders/DuoUniversalTokenProvider.cs#L24

XML comment has badly formed XML -- 'Expected an end tag for element 'summary'.'

Quality scan: src/Core/AdminConsole/OrganizationFeatures/Policies/PolicyValidators/TwoFactorAuthenticationPolicyValidator.cs#L107

Dereference of a possibly null reference.

Quality scan: src/Core/AdminConsole/OrganizationFeatures/OrganizationUsers/UpdateOrganizationUserCommand.cs#L121

Possible null reference argument for parameter 'collections' in 'Task IOrganizationUserRepository.ReplaceAsync(OrganizationUser obj, IEnumerable<CollectionAccessSelection> collections)'.

Quality scan: src/Core/Billing/Services/Implementations/PaymentHistoryService.cs#L15

Parameter 'logger' is unread.

Quality scan: src/Core/Billing/Services/IProviderBillingService.cs#L52

XML comment has cref attribute 'planType' that could not be resolved

Quality scan: src/Core/Settings/GlobalSettings.cs#L110

Using http protocol is insecure. Use https instead. (https://rules.sonarsource.com/csharp/RSPEC-5332)

Quality scan: src/Infrastructure.EntityFramework/AdminConsole/Repositories/OrganizationUserRepository.cs#L251

The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.

Quality scan: bitwarden_license/src/Scim/Controllers/v2/UsersController.cs#L74

ModelState.IsValid should be checked in controller actions. (https://rules.sonarsource.com/csharp/RSPEC-6967)