[EC-529] fix: null providerService

bitwarden · Sep 9, 2022 · cfa0443 · cfa0443
1 parent 8c766e8
commit cfa0443
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/src/Api/Controllers/CiphersController.cs b/src/Api/Controllers/CiphersController.cs
@@ -222,6 +222,12 @@ public async Task<ListResponseModel<CipherMiniDetailsResponseModel>> GetOrganiza
             var responses = orgCiphers.Select(c => new CipherMiniDetailsResponseModel(c, _globalSettings,
                 collectionCiphersGroupDict, c.OrganizationUseTotp));
 
+            var providerId = await _currentContext.ProviderIdForOrg(orgIdGuid);
+            if (providerId.HasValue)
+            {
+                await _providerService.LogProviderAccessToOrganizationAsync(orgIdGuid);
+            }
+
             return new ListResponseModel<CipherMiniDetailsResponseModel>(responses);
         }
 

diff --git a/src/Core/Services/Implementations/CipherService.cs b/src/Core/Services/Implementations/CipherService.cs
@@ -31,7 +31,6 @@ public class CipherService : ICipherService
         private const long _fileSizeLeeway = 1024L * 1024L; // 1MB 
         private readonly IReferenceEventService _referenceEventService;
         private readonly ICurrentContext _currentContext;
-        private readonly IProviderService _providerService;
 
         public CipherService(
             ICipherRepository cipherRepository,
@@ -876,12 +875,6 @@ public async Task RestoreManyAsync(IEnumerable<CipherDetails> ciphers, Guid rest
                 .Where(c => orgCipherIds.Contains(c.CipherId))
                 .GroupBy(c => c.CipherId).ToDictionary(s => s.Key);
 
-            var providerId = await _currentContext.ProviderIdForOrg(organizationId);
-            if (providerId.HasValue)
-            {
-                await _providerService.LogProviderAccessToOrganizationAsync(organizationId);
-            }
-
             return (orgCiphers, collectionCiphersGroupDict);
         }