[PS-2024] Respect name set in BW_SSL_KEY for cert generation #2490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
bitwarden-bot
changed the title
djsmith85
added
the
bw-unified-deploy
Leniwcowaty
approved these changes
Dec 12, 2022
vgrassia
pushed a commit
that referenced
this pull request
Dec 13, 2022
(cherry picked from commit 2469e10)
MGibson1
added a commit
that referenced
this pull request
Dec 14, 2022
* Add Sqlite as EF DB provider Note: In-memory sqlite does not work across projects, since the migrator only runs on the Admin project Co-authored-by: Justin Baur <[email protected]> * Include example sqlite connection string * Add migrator assembly to sqlite connection * Update initial migration to current schema state * dotnet format 🤖 * Update package locks * Respect name set in BW_SSL_KEY for cert generation (#2490) (cherry picked from commit 2469e10) * [PS-2016] Add ability to change UID/GID for Bitwarden unified (#2495) (cherry picked from commit c6fbe8c) * Add SqliteMigrations project to unified Dockerfile Co-authored-by: Justin Baur <[email protected]> Co-authored-by: accolon <[email protected]> Co-authored-by: Vince Grassia <[email protected]>
eliykat
pushed a commit
that referenced
this pull request
Jan 10, 2023
eliykat
pushed a commit
that referenced
this pull request
Jan 10, 2023
* Add Sqlite as EF DB provider Note: In-memory sqlite does not work across projects, since the migrator only runs on the Admin project Co-authored-by: Justin Baur <[email protected]> * Include example sqlite connection string * Add migrator assembly to sqlite connection * Update initial migration to current schema state * dotnet format 🤖 * Update package locks * Respect name set in BW_SSL_KEY for cert generation (#2490) (cherry picked from commit 2469e10) * [PS-2016] Add ability to change UID/GID for Bitwarden unified (#2495) (cherry picked from commit c6fbe8c) * Add SqliteMigrations project to unified Dockerfile Co-authored-by: Justin Baur <[email protected]> Co-authored-by: accolon <[email protected]> Co-authored-by: Vince Grassia <[email protected]>
eliykat
pushed a commit
that referenced
this pull request
Jan 10, 2023
eliykat
pushed a commit
that referenced
this pull request
Jan 10, 2023
* Add Sqlite as EF DB provider Note: In-memory sqlite does not work across projects, since the migrator only runs on the Admin project Co-authored-by: Justin Baur <[email protected]> * Include example sqlite connection string * Add migrator assembly to sqlite connection * Update initial migration to current schema state * dotnet format 🤖 * Update package locks * Respect name set in BW_SSL_KEY for cert generation (#2490) (cherry picked from commit 2469e10) * [PS-2016] Add ability to change UID/GID for Bitwarden unified (#2495) (cherry picked from commit c6fbe8c) * Add SqliteMigrations project to unified Dockerfile Co-authored-by: Justin Baur <[email protected]> Co-authored-by: accolon <[email protected]> Co-authored-by: Vince Grassia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
This small fix makes the
entrypoint.shrespect the key name set viaBW_SSL_KEYin BW Unified'ssettings.env. Before, it always tried to create new certificates when a file namedssl.keywas not found.Fixes #2489.
Code changes
BW_SSL_KEYis set, its value is used instead of the hard-coded valuessl.key.Before you submit
dotnet format --verify-no-changes) (required)