Add nginx to known proxies #3002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGibson1
force-pushed
the
platform/pm-2138/add-nginx-to-known-proxies
branch
from
c151dca to
5ed2a1b
Compare
…d-nginx-to-known-proxies
MGibson1
force-pushed
the
platform/pm-2138/add-nginx-to-known-proxies
branch
from
5ed2a1b to
7be4009
Compare
justindbaur
requested changes
Jun 8, 2023
MGibson1
added a commit
that referenced
this pull request
Jun 21, 2023
* Add nginx to known proxies * Only add nginx proxy if standard self host deployment * Style changes (cherry picked from commit e27ab5d)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
#2847 enabled proxy chains, but in so doing removed our workaround for removing the nginx proxy present in self hosted deployments. It turns out that our middlware was not set up to automatically trust the nginx container run in tandem with our services in a standard self-host deployment. While
knownProxiesglobal settings probably would work to solve this issue, it isn’t a feasible fix because the ips change constantly.This adds the nginx container’s IP to known proxies for standard self-host deployments. Unified does not need it due to localhost being trusted by default.
Before you submit
dotnet format --verify-no-changes) (required)