Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup secrets, use switch instead of bool #3269

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Setup secrets, use switch instead of bool #3269

merged 1 commit into from
Sep 14, 2023

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Sep 14, 2023

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [x] Other

Objective

Change from [bool] to [switch] since it works better cross platform.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

Copy link
Contributor

@amorask-bitwarden amorask-bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hinton Hinton merged commit 1fcf070 into master Sep 14, 2023
40 checks passed
@Hinton Hinton deleted the ps/secret-switch branch September 14, 2023 12:39
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Detailsf97bca80-9ae5-4339-b046-338db31198be

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants