[AC-1693] Send InvoiceUpcoming Notification to Client Owners #3319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amorask-bitwarden
force-pushed
the
billing/AC-1693/send-invoiceupcoming-reseller-client-owner
branch
from
b674504 to
c972048
Compare
amorask-bitwarden
changed the title
|
New Issues
|
There was a problem hiding this comment.
You can update this PR to target billing/PM-212/billing-email-syncing instead of master so as to not pollute the diff with the changes in #3319. Once that PR gets merged and the branch deleted, then this PR will automatically get updated to target master again
amorask-bitwarden
changed the base branch from
master
to
billing/PM-212/billing-email-syncing
djsmith85
reviewed
Oct 4, 2023
@cturnbull-bitwarden Good call! Done. |
src/Infrastructure.EntityFramework/Repositories/OrganizationRepository.cs
Show resolved
Hide resolved
util/Migrator/DbScripts/2023-10-03_00_OrganizationReadOwnerEmailAddresses.sql
Show resolved
Hide resolved
amorask-bitwarden
force-pushed
the
billing/PM-212/billing-email-syncing
branch
from
715bcff to
cc5b4dd
Compare
amorask-bitwarden
force-pushed
the
billing/AC-1693/send-invoiceupcoming-reseller-client-owner
branch
from
c972048 to
a8891af
Compare
amorask-bitwarden
force-pushed
the
billing/PM-212/billing-email-syncing
branch
from
cc5b4dd to
be4658c
Compare
amorask-bitwarden
force-pushed
the
billing/AC-1693/send-invoiceupcoming-reseller-client-owner
branch
from
f8354d1 to
7bebd6e
Compare
amorask-bitwarden
force-pushed
the
billing/PM-212/billing-email-syncing
branch
from
be4658c to
27c099d
Compare
Base automatically changed from
billing/PM-212/billing-email-syncing
to
master
October 11, 2023 19:57
amorask-bitwarden
dismissed
cyprain-okeke’s stale review
The base branch was changed.
amorask-bitwarden
changed the title
Hardened against missing entity IDs in Stripe events in the StripeEventService. Updated ValidateCloudRegion to not use a refresh/expansion for the customer because the invoice.upcoming event does not have an invoice.Id. Updated the StripeController's handling of invoice.upcoming to not use a refresh/expansion for the subscription because the invoice does not have an ID.
amorask-bitwarden
force-pushed
the
billing/AC-1693/send-invoiceupcoming-reseller-client-owner
branch
from
42b09d1 to
c375a64
Compare
cturnbull-bitwarden
previously approved these changes
Oct 23, 2023
cturnbull-bitwarden
approved these changes
Oct 23, 2023
amorask-bitwarden
deleted the
billing/AC-1693/send-invoiceupcoming-reseller-client-owner
branch
cturnbull-bitwarden
pushed a commit
that referenced
this pull request
Nov 1, 2023
* Add Organization_ReadOwnerEmailAddresses SPROC * Add IOrganizationRepository.GetOwnerEmailAddressesById * Add SendInvoiceUpcoming overload for multiple emails * Update InvoiceUpcoming handler to send multiple emails * Cy's feedback * Updates from testing Hardened against missing entity IDs in Stripe events in the StripeEventService. Updated ValidateCloudRegion to not use a refresh/expansion for the customer because the invoice.upcoming event does not have an invoice.Id. Updated the StripeController's handling of invoice.upcoming to not use a refresh/expansion for the subscription because the invoice does not have an ID. * Fix broken test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
This PR updates our handling of the
invoice.upcomingStripe webhook event so that, if the incoming invoice is for an Organization, we send an email notification not only to the organization's billing address, but also to the organization's client owners.❌ This PR is based off an open PR here: #3305. Once this PR is merged, I'll rebase this PR off
master.For review purposes, everything including and after the Add Organization_ReadOwnerEmailAddresses SPROC commit should be reviewed as part of this PR.
Code changes
2023-10-03_00_OrganizationReadOwnerEmailAddresses.sql: Adds a stored procedure to retrieve the email addresses of an organization's client owners.
IOrganizationRepository.cs: Adds
GetOwnerEmailAddressesByIdmethod.OrganizationRepository.cs (Dapper): Adds
GetOwnerEmailAddressesByIdmethod that invokes Stored Procedure.OrganizationRepository.cs (EF): Adds
GetOwnerEmailAddressesByIdmethod that uses EF.IMailService.cs: Adds
SendInvoiceUpcomingoverload.HandlebarsMailService.cs: Adds
SendInvoiceUpcomingoverload.NoopMailService.cs: Adds
SendInvoiceUpcomingoverload.StripeController.cs: Updates
UpcomingInvoicehandling to send the InvoiceUpcoming email notification to both an organization's billing email and client owners separately.Before you submit
dotnet format --verify-no-changes) (required)