Skip to content

[AC-1792] Remove UseKeyConnector field from Enterprise Plan Upgrade#3409

Merged
connerbw merged 1 commit intomasterfrom
AC-1792-Defect-Upgrade-Path-for-2019-Enterprise-Org-Auto-Enables-Key-Connector-With-Customer-Encryption
Nov 3, 2023
Merged

[AC-1792] Remove UseKeyConnector field from Enterprise Plan Upgrade#3409
connerbw merged 1 commit intomasterfrom
AC-1792-Defect-Upgrade-Path-for-2019-Enterprise-Org-Auto-Enables-Key-Connector-With-Customer-Encryption

Conversation

@connerbw
Copy link
Copy Markdown
Contributor

@connerbw connerbw commented Nov 3, 2023

Type of change

- [X] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

As a part of #3320, I mistaken enabled UseKeyConnector for old 2019 enterprise orgs, where it should have been left disabled. Since this script has not been deployed yet, I modified the existing script to catch the error.

Code changes

  • DbScripts\2023-10-13_01_2019EnterprisePlanFeatureUpgrade.sql: Removed the update to UseKeyConnector

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@connerbw connerbw requested a review from a team as a code owner November 3, 2023 19:44
@connerbw connerbw enabled auto-merge (squash) November 3, 2023 19:55
@bitwarden-bot
Copy link
Copy Markdown

Logo
Checkmarx One – Scan Summary & Details7ab5c543-74ab-4caf-b863-e06366612491

No New Or Fixed Issues Found

@connerbw connerbw merged commit 92ffe5f into master Nov 3, 2023
@connerbw connerbw deleted the AC-1792-Defect-Upgrade-Path-for-2019-Enterprise-Org-Auto-Enables-Key-Connector-With-Customer-Encryption branch November 3, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants