[AC-1682] Flexible collections: data migrations for deprecated permissions #3437

r-tome · 2023-11-10T16:19:54Z

Type of change

- [ ] Bug fix
- [X] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

With Flexible Collections, the Manager role and 'EditAssignedCollections' permission are deprecated. Therefore, we must explicitly grant access to those users for the collections they previously had access to, but now with the new Manage permission. Additionally, users and groups with the AccessAll permission will now have access to all collections within their organizations.

Code changes

util/Migrator/DbScripts/2023-11-10_00_AccessAllCollectionGroups.sql: Add entries to [dbo].[CollectionGroup] with [Manage] = 1 for all groups with 'AccessAll' permission
util/Migrator/DbScripts/2023-11-10_00_AccessAllCollectionUsers.sql: Add entries to [dbo].[CollectionUser] with [Manage] = 1 for all organization users with 'AccessAll' permission
util/Migrator/DbScripts/2023-11-10_00_ManagersEditAssignedCollectionUsers.sql: Update [dbo].[CollectionUser] with [Manage] = 1 for all users with Manager role or 'EditAssignedCollections' permission

Before you submit

Please check for formatting errors (dotnet format --verify-no-changes) (required)
If making database changes - make sure you also update Entity Framework queries and/or migrations
Please add unit tests where it makes sense to do so (encouraged but not required)
If this change requires a documentation update - notify the documentation team
If this change has particular deployment requirements - notify the DevOps team

… = 1 for all users with Manager role or 'EditAssignedCollections' permission

bitwarden-bot · 2023-11-10T16:52:39Z

Checkmarx One – Scan Summary & Details – ab18185d-3294-4015-9196-0047dd984927

Fixed Issues

Severity	Issue	Source File / Package
	Missing User Instruction	/Dockerfile: 1
	Missing User Instruction	/Dockerfile: 1
	Missing User Instruction	/Dockerfile: 1
	Missing User Instruction	/Dockerfile: 1
	Missing User Instruction	/Dockerfile: 1
	Missing User Instruction	/Dockerfile: 1
	Missing User Instruction	/Dockerfile: 1
	Missing User Instruction	/Dockerfile: 1
	Missing User Instruction	/Dockerfile: 1
	Missing User Instruction	/Dockerfile: 1
	Missing User Instruction	/Dockerfile: 1
	Missing User Instruction	/Dockerfile: 1
	Missing User Instruction	/Dockerfile: 1
	Missing User Instruction	/Dockerfile: 1
	Missing User Instruction	/Dockerfile: 1
	Passwords And Secrets - Generic Password	/test-database.yml: 93
	Passwords And Secrets - Generic Password	/test-database.yml: 74
	Passwords And Secrets - Generic Password	/test-database.yml: 159
	Passwords And Secrets - Generic Password	/test-database.yml: 87
	Passwords And Secrets - Generic Password	/test-database.yml: 155
	Reflected_XSS_All_Clients	/src/Admin/Views/Shared/_OrganizationFormScripts.cshtml: 166
	Reflected_XSS_All_Clients	/bitwarden_license/src/Sso/Views/Shared/Error.cshtml: 10
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	Apt Get Install Pin Version Not Defined	/Dockerfile: 7
	Apt Get Install Pin Version Not Defined	/Dockerfile-k8s: 8
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	Apt Get Install Pin Version Not Defined	/Dockerfile: 7
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	Apt Get Install Pin Version Not Defined	/Dockerfile-k8s: 8
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	Apt Get Install Pin Version Not Defined	/Dockerfile: 5
	CSRF	/src/Identity/Controllers/AccountsController.cs: 73
	CSRF	/src/Identity/Controllers/AccountsController.cs: 51
	CSRF	/src/Api/Vault/Controllers/FoldersController.cs: 45
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 587
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 114
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 100
	CSRF	/src/Api/Tools/Controllers/ImportCiphersController.cs: 56
	CSRF	/src/Api/Tools/Controllers/ImportCiphersController.cs: 40
	CSRF	/src/Api/Controllers/SelfHosted/SelfHostedOrganizationLicensesController.cs: 51
	CSRF	/src/Api/Controllers/UsersController.cs: 22
	CSRF	/src/Api/Controllers/DevicesController.cs: 70
	CSRF	/src/Api/Controllers/DevicesController.cs: 57
	CSRF	/src/Api/Controllers/CollectionsController.cs: 198
	CSRF	/src/Api/Controllers/CollectionsController.cs: 189
	CSRF	/src/Api/Controllers/CollectionsController.cs: 158
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 542
	CSRF	/src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 69
	CSRF	/src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 49
	CSRF	/src/Api/AdminConsole/Public/Controllers/OrganizationController.cs: 42
	CSRF	/src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 92
	CSRF	/src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 49
	CSRF	/src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 142
	CSRF	/src/Api/AdminConsole/Controllers/ProviderOrganizationsController.cs: 52
	CSRF	/src/Api/AdminConsole/Controllers/PoliciesController.cs: 148
	CSRF	/src/Api/AdminConsole/Controllers/PoliciesController.cs: 78
	CSRF	/src/Api/AdminConsole/Controllers/PoliciesController.cs: 61
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 280
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 262
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 180
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 77
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 526
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 302
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 201
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 104
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 67
	CSRF	/src/Admin/Controllers/ProvidersController.cs: 175
	CSRF	/src/Admin/Controllers/OrganizationsController.cs: 284
	CSRF	/bitwarden_license/src/Sso/Controllers/AccountController.cs: 163
	CSRF	/bitwarden_license/src/Sso/Controllers/AccountController.cs: 96
	CSRF	/bitwarden_license/src/Scim/Controllers/v2/UsersController.cs: 50
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 209
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 295
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 355
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 553
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 442
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 248
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 193
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 118
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 208
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 316
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 424
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 415
	CSRF	/src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 161
	CSRF	/src/Api/Controllers/SettingsController.cs: 36
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 209
	CSRF	/src/Api/Auth/Controllers/EmergencyAccessController.cs: 159
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 556
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 135
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 135
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 263
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 526
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 865
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 386
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 390
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 270
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 148
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 292
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 292
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 924
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 308
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 308
	CSRF	/src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 188
	CSRF	/bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 98
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 255
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 456
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 691
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 691
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 642
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 642
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 725
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 180
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 668
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 668
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 163
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 789
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 268
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 268
	CSRF	/src/Api/Auth/Controllers/TwoFactorController.cs: 403
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 526
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 526
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 526
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 745
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 255
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 292
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 292
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 133
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 523
	CSRF	/src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 175
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 180
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 568
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 151
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 344
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 248
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 595
	CSRF	/src/Api/AdminConsole/Public/Controllers/OrganizationController.cs: 42
	CSRF	/src/Api/AdminConsole/Public/Controllers/OrganizationController.cs: 42
	CSRF	/src/Api/AdminConsole/Public/Controllers/OrganizationController.cs: 42
	CSRF	/bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 88
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 208
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 295
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 295
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 176
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 367
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 204

More results are available on AST platform

r-tome · 2023-11-10T18:11:03Z

EF migrations are missing at this moment, I will add them soon.

…mmendations

eliykat · 2023-11-13T15:44:59Z

Data migrations should be in the dbScripts_transition please, we want a bit of control over when they're run rather than being run automatically on deployment.

rkac-bw

Looks good to me

eliykat · 2023-11-23T22:53:56Z

For visibility - I'm working through your other PRs first which I think are higher priority, so I probably won't get to this until next week.

eliykat · 2023-12-05T05:57:41Z

Started looking at this today, but would like a second review from another Flexible Collections expert.

eliykat · 2023-12-05T05:54:16Z

util/Migrator/DbScripts_transition/2023-11-10_00_AccessAllCollectionGroups.sql

+    FROM [dbo].[CollectionGroup] CG
+INNER JOIN [dbo].[Collection] C ON CG.[CollectionId] = C.[Id]
+INNER JOIN #TempGroup TG ON CG.[GroupId] = TG.[GroupId]
+WHERE C.[OrganizationId] = TG.[OrganizationId];


I'm not 100% sure, but is this WHERE clause doing anything?

The INNER JOIN ensures that records exist in both tables, so if we INNER JOIN CollectionGroup, Collection and TempGroup, we should only end up with CollectionGroup records for Groups where AccessAll = 1. Then we can update the values without reference to the orgId. I think.

That said, I'm happy to leave it if that's safer or if there's another reason.

@rkac-bw

You're right, it also seems redundant to me, but perhaps its for performance reasons.

No performance gain with where clause, if does not add anything then it can be removed

util/Migrator/DbScripts_transition/2023-11-10_00_AccessAllCollectionGroups.sql

util/Migrator/DbScripts_transition/2023-11-10_00_AccessAllCollectionUsers.sql

util/Migrator/DbScripts_transition/2023-11-10_00_AccessAllCollectionGroups.sql

util/Migrator/DbScripts_transition/2023-11-10_00_AccessAllCollectionUsers.sql

util/Migrator/DbScripts_transition/2023-11-10_00_AccessAllCollectionGroups.sql

util/Migrator/DbScripts_transition/2023-11-10_00_AccessAllCollectionUsers.sql

util/Migrator/DbScripts_transition/2023-11-10_00_ManagersEditAssignedCollectionUsers.sql

…lection assignments Co-authored-by: Thomas Rittson <[email protected]>

…signedCollectionUsers sql script

…o file name

…permissions

eliykat

Great work on this.

@rkac-bw could you please check the latest changes in response to my feedback. Thanks

util/Migrator/DbScripts_transition/2023-12-06_02_ManagersEditAssignedCollectionUsers.sql

…EditAssignedCollections permission assigned to groups with collection access

…ion dates at the same time

r-tome · 2024-01-18T16:35:13Z

@eliykat / @rkac-bw I have removed the cursors from the script and also combined all distinct OrganizationUserId into one variable and then use that to bump all revision dates in one go. Does it make sense or is it safer to update them once per step like before?

eliykat

I know this has been a lot of work and revisions, thanks for putting the time in to be the expert on these changes. I have a few questions below.

src/Sql/dbo/Stored Procedures/Organization_EnableCollectionEnhancements.sql

eliykat · 2024-01-22T05:08:14Z

src/Sql/dbo/Stored Procedures/Organization_EnableCollectionEnhancements.sql

+                -- Step 2
+                    -- Update existing rows in [dbo].[CollectionUser]
+                    UPDATE target
+                    SET
+                        target.[ReadOnly] = 0,
+                        target.[HidePasswords] = 0,
+                        target.[Manage] = 0
+                        FROM [dbo].[CollectionUser] AS target
+                        INNER JOIN (
+                            SELECT C.[Id] AS [CollectionId], T.[OrganizationUserId]
+                            FROM [dbo].[Collection] C
+                            INNER JOIN #TempStep2 T ON C.[OrganizationId] = T.[OrganizationId]
+                        ) AS source
+                    ON target.[CollectionId] = source.[CollectionId] AND target.[OrganizationUserId] = source.[OrganizationUserId];
+
+                    -- Insert new rows into [dbo].[CollectionUser]
+                    INSERT INTO [dbo].[CollectionUser] ([CollectionId], [OrganizationUserId], [ReadOnly], [HidePasswords], [Manage])
+                    SELECT source.[CollectionId], source.[OrganizationUserId], 0, 0, 0
+                    FROM (
+                             SELECT C.[Id] AS [CollectionId], T.[OrganizationUserId]
+                             FROM [dbo].[Collection] C
+                                 INNER JOIN #TempStep2 T ON C.[OrganizationId] = T.[OrganizationId]
+                         ) AS source
+                    LEFT JOIN [dbo].[CollectionUser] AS target
+                        ON target.[CollectionId] = source.[CollectionId] AND target.[OrganizationUserId] = source.[OrganizationUserId]
+                    WHERE target.[CollectionId] IS NULL;


💭 Why doesn't this follow the same pattern/structure as Step 1? I thought it would be pretty similar because it's the same thing but for orgUsers instead of Groups. However, this uses target/source naming and has nested SELECT queries. Is there some difference here that I'm missing or is this just a result of removing the batching logic?

That makes sense and its easier to read. I have rewritten those parts here, what do you think?

UPDATE target SET target.[ReadOnly] = 0, target.[HidePasswords] = 0, target.[Manage] = 0 FROM [dbo].[CollectionUser] AS target INNER JOIN [dbo].[Collection] AS C ON target.[CollectionId] = C.[Id] INNER JOIN #TempUsersAccessAll AS TU ON C.[OrganizationId] = TU.[OrganizationId] AND target.[OrganizationUserId] = TU.[OrganizationUserId];

INSERT INTO [dbo].[CollectionUser] ([CollectionId], [OrganizationUserId], [ReadOnly], [HidePasswords], [Manage]) SELECT C.[Id] AS [CollectionId], TU.[OrganizationUserId], 0, 0, 0 FROM [dbo].[Collection] C INNER JOIN #TempUsersAccessAll TU ON C.[OrganizationId] = TU.[OrganizationId] LEFT JOIN [dbo].[CollectionUser] target ON target.[CollectionId] = C.[Id] AND target.[OrganizationUserId] = TU.[OrganizationUserId] WHERE target.[CollectionId] IS NULL;

@rkac-bw will perform some testing to see if there isn't any performance loss.

src/Sql/dbo/Stored Procedures/Organization_EnableCollectionEnhancements.sql

…ancements.sql Co-authored-by: Thomas Rittson <[email protected]>

https://github.com/bitwarden/server into ac/ac-1682/data-migrations-for-deprecated-permissions

…Only] = 0 and [HidePasswords] = 0

…th [ReadOnly] = 0 and [HidePasswords] = 0" This reverts commit 086c88f.

src/Sql/dbo/Stored Procedures/Organization_EnableCollectionEnhancements.sql

rkac-bw

looks good to me

r-tome added 2 commits November 10, 2023 15:28

[AC-1682] Data migrations for OrgUsers or Groups with AccessAll enabled

e14ba4d

[AC-1682] Added script to update [dbo].[CollectionUser] with [Manage]…

1527af7

… = 1 for all users with Manager role or 'EditAssignedCollections' permission

r-tome requested a review from eliykat November 10, 2023 16:26

r-tome marked this pull request as ready for review November 10, 2023 16:26

r-tome requested a review from a team as a code owner November 10, 2023 16:26

[AC-1682] Updated sql data migration procedures with performance reco…

577e591

…mmendations

[AC-1682] Moved data migration scripts to DbScripts_transition folder

23a3e5c

rkac-bw previously approved these changes Nov 16, 2023

View reviewed changes

eliykat added the hold Hold this PR or item until later; DO NOT MERGE label Nov 23, 2023

eliykat requested review from shane-melton and vincentsalucci December 5, 2023 05:57

eliykat removed the hold Hold this PR or item until later; DO NOT MERGE label Dec 5, 2023

eliykat requested changes Dec 6, 2023

View reviewed changes

r-tome dismissed rkac-bw’s stale review via d693511 December 6, 2023 15:46

r-tome and others added 5 commits December 6, 2023 15:46

Apply suggestions from code review: Remove Manage permission from Col…

d693511

…lection assignments Co-authored-by: Thomas Rittson <[email protected]>

[AC-1682] Removed unnecessary Collection table join on ManagersEditAs…

0475b93

…signedCollectionUsers sql script

[AC-1682] Change JOIN to INNER JOIN in SQL scripts

3e7e3a0

[AC-1682] Renamed sql script to recent date and added correct order t…

be35a2b

…o file name

Merge branch 'master' into ac/ac-1682/data-migrations-for-deprecated-…

b7773b6

…permissions

r-tome requested review from rkac-bw and eliykat December 6, 2023 16:20

eliykat reviewed Dec 7, 2023

View reviewed changes

eliykat approved these changes Dec 7, 2023

View reviewed changes

eliykat requested changes Dec 18, 2023

View reviewed changes

util/Migrator/DbScripts_transition/2023-12-06_02_ManagersEditAssignedCollectionUsers.sql Outdated Show resolved Hide resolved

[AC-1682] Add new rows to CollectionUser for Managers and users with …

7d718b6

…EditAssignedCollections permission assigned to groups with collection access

[AC-1682] Combining all updated OrganizationUserIds to bump all revis…

6a519b9

…ion dates at the same time

eliykat requested changes Jan 22, 2024

View reviewed changes

r-tome and others added 3 commits January 22, 2024 13:05

Update src/Sql/dbo/Stored Procedures/Organization_EnableCollectionEnh…

6579ede

…ancements.sql Co-authored-by: Thomas Rittson <[email protected]>

[AC-1682] Renamed aliases

ea244df

Merge branch 'ac/ac-1682/data-migrations-for-deprecated-permissions' of

7dbb9e6

https://github.com/bitwarden/server into ac/ac-1682/data-migrations-for-deprecated-permissions

eliykat mentioned this pull request Jan 23, 2024

[AC-2026] Add UI and endpoint to set organization property #3643

Merged

r-tome requested review from eliykat and rkac-bw January 23, 2024 07:23

r-tome added 6 commits January 23, 2024 14:12

[AC-1682] Simplified inner queries

0144c25

[AC-1682] Bumping each modified groups RevisionDate

1e2a15d

[AC-1682] Removed updating CollectionUser existing records with [Read…

086c88f

…Only] = 0 and [HidePasswords] = 0

[AC-1682] Updating OrganizationUser RevisionDate

6fa4687

[AC-1682] Updated the stored procedure file

f1fb994

[AC-1682] Selecting distinct values to insert into CollectionUser table

ebecc69

eliykat removed request for shane-melton and vincentsalucci January 25, 2024 03:52

r-tome added 2 commits January 25, 2024 07:10

Revert "[AC-1682] Removed updating CollectionUser existing records wi…

737b81f

…th [ReadOnly] = 0 and [HidePasswords] = 0" This reverts commit 086c88f.

[AC-1682] Bumped up the date on the migration script

5cc8912

eliykat previously approved these changes Jan 25, 2024

View reviewed changes

rkac-bw reviewed Jan 25, 2024

View reviewed changes

src/Sql/dbo/Stored Procedures/Organization_EnableCollectionEnhancements.sql Show resolved Hide resolved

rkac-bw reviewed Jan 25, 2024

View reviewed changes

src/Sql/dbo/Stored Procedures/Organization_EnableCollectionEnhancements.sql Show resolved Hide resolved

[AC-1682] Updating OrganizationUser RevisionDate

f14e04c

r-tome dismissed eliykat’s stale review via f14e04c January 25, 2024 12:32

rkac-bw approved these changes Jan 25, 2024

View reviewed changes

r-tome removed the hold Hold this PR or item until later; DO NOT MERGE label Jan 25, 2024

r-tome merged commit bac0676 into main Jan 25, 2024
87 of 89 checks passed

r-tome deleted the ac/ac-1682/data-migrations-for-deprecated-permissions branch January 25, 2024 14:08

r-tome mentioned this pull request Mar 3, 2024

[AC-1682] Flexible collections: EF data migrations for deprecated permissions #3864

Closed

r-tome mentioned this pull request Apr 10, 2024

[AC-1978] Flexible collections: EF data migrations for deprecated permissions #3969

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AC-1682] Flexible collections: data migrations for deprecated permissions #3437

[AC-1682] Flexible collections: data migrations for deprecated permissions #3437

r-tome commented Nov 10, 2023 •

edited

Loading

bitwarden-bot commented Nov 10, 2023 •

edited

Loading

r-tome commented Nov 10, 2023

eliykat commented Nov 13, 2023 •

edited

Loading

rkac-bw left a comment

eliykat commented Nov 23, 2023 •

edited

Loading

eliykat commented Dec 5, 2023

eliykat Dec 5, 2023

r-tome Dec 6, 2023

rkac-bw Dec 7, 2023

eliykat left a comment

r-tome commented Jan 18, 2024

eliykat left a comment

eliykat Jan 22, 2024

r-tome Jan 23, 2024

rkac-bw Jan 24, 2024

rkac-bw left a comment

[AC-1682] Flexible collections: data migrations for deprecated permissions #3437

[AC-1682] Flexible collections: data migrations for deprecated permissions #3437

Conversation

r-tome commented Nov 10, 2023 • edited Loading

Type of change

Objective

Code changes

Before you submit

bitwarden-bot commented Nov 10, 2023 • edited Loading

Fixed Issues

r-tome commented Nov 10, 2023

eliykat commented Nov 13, 2023 • edited Loading

rkac-bw left a comment

Choose a reason for hiding this comment

eliykat commented Nov 23, 2023 • edited Loading

eliykat commented Dec 5, 2023

eliykat Dec 5, 2023

Choose a reason for hiding this comment

r-tome Dec 6, 2023

Choose a reason for hiding this comment

rkac-bw Dec 7, 2023

Choose a reason for hiding this comment

eliykat left a comment

Choose a reason for hiding this comment

r-tome commented Jan 18, 2024

eliykat left a comment

Choose a reason for hiding this comment

eliykat Jan 22, 2024

Choose a reason for hiding this comment

r-tome Jan 23, 2024

Choose a reason for hiding this comment

rkac-bw Jan 24, 2024

Choose a reason for hiding this comment

rkac-bw left a comment

Choose a reason for hiding this comment

r-tome commented Nov 10, 2023 •

edited

Loading

bitwarden-bot commented Nov 10, 2023 •

edited

Loading

eliykat commented Nov 13, 2023 •

edited

Loading

eliykat commented Nov 23, 2023 •

edited

Loading