[PM-3570] Adjust refresh token lifetimes

[kspearrin]

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Adjusting token lifetimes to be in line with normal use cases.

Fix grant delete implementation for EF.

Code changes

• StaticClientStore.cs: Adjust lifetimes of refresh tokens for mobile and web.
• GrantRepository.cs: Fix delete functions for EF. They were not working since there were never tested before.

Before you submit

• Please check for formatting errors (dotnet format --verify-no-changes) (required)
• If making database changes - make sure you also update Entity Framework queries and/or migrations
• Please add unit tests where it makes sense to do so (encouraged but not required)
• If this change requires a documentation update - notify the documentation team
• If this change has particular deployment requirements - notify the DevOps team

[withinfocus]

Test TokenEndpoint_GrantTypeRefreshToken_Success fails, I think due to a refresh token comparison.

Before this lands we have to confirm that all clients are re-storing the returned refresh token. We think that was the case but weren't sure 100%.

Additionally, is there any risk of hardcoded lifetimes in the clients?

[kspearrin]

Test TokenEndpoint_GrantTypeRefreshToken_Success fails, I think due to a refresh token comparison.

Before this lands we have to confirm that all clients are re-storing the returned refresh token. We think that was the case but weren't sure 100%.

Additionally, is there any risk of hardcoded lifetimes in the clients?

Looks like its doing some new functionality with onetime use. I see it trying to delete the old token from the grant store after it creates the new one. Cool.

System.InvalidOperationException: The entity type 'EntityQueryable<Grant>' was not found. Ensure that the entity type has been added to the model.
   at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.StateManager.GetOrCreateEntry(Object entity)
   at Microsoft.EntityFrameworkCore.DbContext.EntryWithoutDetectChanges[TEntity](TEntity entity)
   at Microsoft.EntityFrameworkCore.DbContext.Remove[TEntity](TEntity entity)
   at Bit.Infrastructure.EntityFramework.Auth.Repositories.GrantRepository.DeleteByKeyAsync(String key) in .\server\src\Infrastructure.EntityFramework\Auth\Repositories\GrantRepository.cs:line 25
   at Bit.Identity.IdentityServer.PersistedGrantStore.RemoveAsync(String key) in .\server\src\Identity\IdentityServer\PersistedGrantStore.cs:line 56
   at Duende.IdentityServer.Stores.DefaultGrantStore`1.RemoveItemByHashedKeyAsync(String key) in /_/src/IdentityServer/Stores/Default/DefaultGrantStore.cs:line 248
   at Duende.IdentityServer.Services.DefaultRefreshTokenService.UpdateRefreshTokenAsync(RefreshTokenUpdateRequest request) in /_/src/IdentityServer/Services/Default/DefaultRefreshTokenService.cs:line 250
   at Duende.IdentityServer.ResponseHandling.TokenResponseGenerator.ProcessRefreshTokenRequestAsync(TokenRequestValidationResult request) in /_/src/IdentityServer/ResponseHandling/Default/TokenResponseGenerator.cs:line 220

[bitwarden-bot]

Checkmarx One – Scan Summary & Details – dade1086-95fb-4893-a7e0-0660251296c8

No New Or Fixed Issues Found

[codecov]

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (9ecc479) 39.32% compared to head (b6aa272) 38.82%.

❗ Current head b6aa272 differs from pull request most recent head 28ca080. Consider uploading reports for the commit 28ca080 to get more accurate results

Files	Patch %	Lines
...tityFramework/Auth/Repositories/GrantRepository.cs	0.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3697      +/-   ##
==========================================
- Coverage   39.32%   38.82%   -0.50%     
==========================================
  Files        1032     1034       +2     
  Lines       51056    51105      +49     
  Branches     4581     4577       -4     
==========================================
- Hits        20076    19843     -233     
- Misses      30036    30330     +294     
+ Partials      944      932      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[withinfocus]

Change makes sense to me. Let's ensure client compliance before we merge anything.

We'll want to ensure this acts as expected with our Cosmos store too, and meeting performance expectations for deletes.