Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-5807] Update mssql to CU12 to support linux kernel 6.7.x #3904

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

djsmith85
Copy link
Contributor

@djsmith85 djsmith85 commented Mar 15, 2024

Type of change

- [X] Bug fix
- [ ] New feature development
- [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Fixes #3689

This was an upstream issue with the MSSQL image from Microsoft. Per user reports this has been addressed with 2022-CU12.

Code changes

  • util/MsSql/Dockerfile: Bump mssql image to 2022-CU12 from 2022-CU11

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@djsmith85 djsmith85 requested a review from a team as a code owner March 15, 2024 15:29
@djsmith85 djsmith85 requested a review from a team March 15, 2024 15:31
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.19%. Comparing base (1e5f6ff) to head (183c645).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3904   +/-   ##
=======================================
  Coverage   36.19%   36.19%           
=======================================
  Files        1158     1158           
  Lines       56108    56108           
  Branches     5385     5385           
=======================================
  Hits        20307    20307           
- Misses      34855    34856    +1     
+ Partials      946      945    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djsmith85 djsmith85 enabled auto-merge (squash) March 15, 2024 16:07
Copy link
Contributor

@rkac-bw rkac-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@djsmith85 djsmith85 merged commit 2b440ed into main Mar 15, 2024
50 checks passed
@djsmith85 djsmith85 deleted the tools/pm-5807/update-mssql-image-to-cu12 branch March 15, 2024 19:02
@CryptoSiD
Copy link

When can we expect a new release with the fix applied?

@djsmith85
Copy link
Contributor Author

We are expecting to release self-hosted roughly by end of the week.

djsmith85 added a commit that referenced this pull request Mar 18, 2024
Co-authored-by: Daniel James Smith <[email protected]>
(cherry picked from commit 2b440ed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mssql repeatedly crashing under kernel 6.7.0
5 participants