Turn on LimitCollectionCreationDeletionSplit for self host

[addisonbeck]

🎟️ Tracking

🧵 Jira Ticket: PM-10863

📚 Stacked PRs

1. server: Split LimitCollectionCreationDeletion into two database columns #4709
2. server: Split Organization.LimitCollectionCreationDeletion into two separate business rules #4730
3. clients: Split Organization.LimitCollectionCreationDeletion into two separate business rules clients#11223
4. server: Turn on LimitCollectionCreationDeletionSplit for self host #4808
   ⬆️ YOU ARE HERE
5. server: [PM-14821] [PM-14822] Remove LimitCollectionCreationDeletionSplit feature flag #4809
6. clients: [PM-14821] Remove LimitCollectionCreationDeletionSplit feature flag clients#11258
7. server: Drop LimitCollectionCreationDeletion from the database #4810

📔 Objective

🤳 The Bigger Picture

There is an option in the Admin Console that removes collection creation and
deletion controls from all organization members that are not in the Owner and
Admin roles. This PR stack splits this conjoined option into two separate
controls: one to block create operations and one to block delete
operations. This is a part of an effort to make these settings better align
with what customers expect it to do.

👉 This Pull Request 👍

Over the last two PRs we implemented the functional changes requested in this
body of work in server and clients. This PR is much more simple. It just
enables the feature for self hosted installations by manually setting the
feature flag to true.

This PR and the previous two in the stack encompass all of the functional
changes to the system in this PR stack. By now all requested functionality
should be deployed and available to customers. The next three pull requests
are maintenance tasks to support evolutionary database design and feature
toggling.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – eb6fa4c1-ea63-4e3d-87c5-fd389d073372

Fixed Issues

Severity	Issue	Source File / Package
	Unpinned Actions Full Length Commit SHA	/build.yml: 579
	Unpinned Actions Full Length Commit SHA	/repository-management.yml: 153
	Unpinned Actions Full Length Commit SHA	/repository-management.yml: 96
	Unpinned Actions Full Length Commit SHA	/build.yml: 545
	Unpinned Actions Full Length Commit SHA	/build.yml: 664
	Unpinned Actions Full Length Commit SHA	/repository-management.yml: 168
	Unpinned Actions Full Length Commit SHA	/repository-management.yml: 160
	Unpinned Actions Full Length Commit SHA	/build.yml: 220
	Unpinned Actions Full Length Commit SHA	/build.yml: 616

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 42.66%. Comparing base (e16cad5) to head (a3599d8).
Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
src/Core/Constants.cs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4808      +/-   ##
==========================================
- Coverage   42.66%   42.66%   -0.01%     
==========================================
  Files        1411     1411              
  Lines       65087    65088       +1     
  Branches     5959     5959              
==========================================
  Hits        27772    27772              
- Misses      36075    36076       +1     
  Partials     1240     1240              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[eliykat]

LGTM although we need to figure out the timing, see #4730 (comment).

[eliykat]

Ignoring this as discussed given that you are planning on just removing the flagged code.