Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-7452] Resolve PayPal issue #4855

Closed
wants to merge 7 commits into from
Closed

[PM-7452] Resolve PayPal issue #4855

wants to merge 7 commits into from

Conversation

amorask-bitwarden
Copy link
Contributor

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@codecov Codecov
Copy link

codecov bot commented Oct 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.

Project coverage is 41.64%. Comparing base (d4c486e) to head (cc23d81).
Report is 64 commits behind head on main.

Files with missing lines Patch % Lines
...vices/Implementations/StripeEventUtilityService.cs 0.00% 32 Missing ⚠️
.../Services/Implementations/InvoiceCreatedHandler.cs 0.00% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4855      +/-   ##
==========================================
- Coverage   41.66%   41.64%   -0.03%     
==========================================
  Files        1360     1360              
  Lines       63888    63924      +36     
  Branches     5862     5866       +4     
==========================================
  Hits        26620    26620              
- Misses      36061    36097      +36     
  Partials     1207     1207

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 0e9edb00-fc87-49d8-83f0-8a179e5cf462

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 366 Attack Vector
MEDIUM CSRF /src/Billing/Controllers/StripeController.cs: 176 Attack Vector
MEDIUM CSRF /src/Api/Auth/Controllers/TwoFactorController.cs: 290 Attack Vector
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 247 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 238 Attack Vector
MEDIUM Privacy_Violation /src/Core/Services/Implementations/UserService.cs: 860 Attack Vector
MEDIUM Privacy_Violation /src/Core/Auth/UserFeatures/TdeOffboardingPassword/TdeOffboardingPasswordCommand.cs: 81 Attack Vector
MEDIUM Privacy_Violation /src/Core/Auth/UserFeatures/TdeOffboardingPassword/TdeOffboardingPasswordCommand.cs: 81 Attack Vector
MEDIUM Privacy_Violation /src/Api/Vault/Models/Request/CipherRequestModel.cs: 198 Attack Vector
MEDIUM Privacy_Violation /src/Core/Auth/UserFeatures/UserMasterPassword/SetInitialMasterPasswordCommand.cs: 59 Attack Vector
MEDIUM Privacy_Violation /src/Core/Auth/UserFeatures/UserMasterPassword/SetInitialMasterPasswordCommand.cs: 59 Attack Vector
MEDIUM Privacy_Violation /src/Core/Services/Implementations/UserService.cs: 575 Attack Vector
MEDIUM Privacy_Violation /src/Core/Services/Implementations/UserService.cs: 522 Attack Vector
MEDIUM Privacy_Violation /src/Core/Services/Implementations/UserService.cs: 522 Attack Vector
MEDIUM Privacy_Violation /src/Core/Services/Implementations/UserService.cs: 577 Attack Vector
MEDIUM Privacy_Violation /src/Core/Services/Implementations/UserService.cs: 577 Attack Vector
MEDIUM Privacy_Violation /src/Core/Services/Implementations/UserService.cs: 718 Attack Vector
MEDIUM Privacy_Violation /src/Core/Services/Implementations/UserService.cs: 744 Attack Vector
MEDIUM Privacy_Violation /src/Core/Services/Implementations/UserService.cs: 744 Attack Vector
MEDIUM Privacy_Violation /src/Core/Services/Implementations/UserService.cs: 773 Attack Vector
MEDIUM Privacy_Violation /src/Core/Services/Implementations/UserService.cs: 773 Attack Vector
MEDIUM Privacy_Violation /src/Core/Services/Implementations/UserService.cs: 771 Attack Vector
MEDIUM SSL_Verification_Bypass /src/Api/Auth/Models/Request/OrganizationSsoRequestModel.cs: 146 Attack Vector
MEDIUM SSL_Verification_Bypass /bitwarden_license/src/Sso/Utilities/DynamicAuthenticationSchemeProvider.cs: 405 Attack Vector
MEDIUM SSL_Verification_Bypass /src/Core/Utilities/CoreHelpers.cs: 105 Attack Vector
MEDIUM SSL_Verification_Bypass /src/Core/Utilities/CoreHelpers.cs: 140 Attack Vector
MEDIUM SSL_Verification_Bypass /src/Core/Utilities/CoreHelpers.cs: 93 Attack Vector
MEDIUM SSL_Verification_Bypass /src/Core/Utilities/CoreHelpers.cs: 115 Attack Vector
LOW Log_Forging /src/Notifications/Controllers/SendController.cs: 27 Attack Vector
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 574 Attack Vector
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 553 Attack Vector
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 530 Attack Vector
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 603 Attack Vector
LOW Log_Forging /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 98 Attack Vector
LOW Open_Redirect /src/Admin/Controllers/ToolsController.cs: 490 Attack Vector
LOW Open_Redirect /bitwarden_license/src/Sso/Controllers/AccountController.cs: 167 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Billing/Controllers/RecoveryController.cs: 38
MEDIUM CSRF /src/Api/Billing/Controllers/OrganizationsController.cs: 105
MEDIUM CSRF /src/Api/Billing/Controllers/OrganizationsController.cs: 49
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 78
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 61
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/MembersController.cs: 93
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 224
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 78
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 61
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 348
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 331
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 250
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 46
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 66
MEDIUM CSRF /src/Api/SecretsManager/Controllers/SecretsController.cs: 79
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 292
MEDIUM CSRF /src/Api/SecretsManager/Controllers/SecretsController.cs: 128
MEDIUM CSRF /src/Api/SecretsManager/Controllers/SecretsTrashController.cs: 32
MEDIUM Privacy_Violation /src/Api/Auth/Models/Request/Accounts/SetPasswordRequestModel.cs: 28
MEDIUM Privacy_Violation /src/Core/Services/Implementations/UserService.cs: 1293
LOW Heap_Inspection /src/Core/Vault/Services/Implementations/LocalAttachmentStorageService.cs: 34
LOW Heap_Inspection /src/Api/Vault/Controllers/CiphersController.cs: 1125
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Api/AdminConsole/Controllers/ProvidersController.cs: 72
LOW Log_Forging /src/Api/AdminConsole/Controllers/ProvidersController.cs: 72
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Identity/Billing/Controller/AccountsController.cs: 23
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Api/Billing/Controllers/ProviderBillingController.cs: 52
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164

@amorask-bitwarden amorask-bitwarden deleted the billing/PM-7452/resolve-paypal-issue branch October 31, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amorask-bitwarden @bitwarden-devops-bot