Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11505] Delete the feature flag PM-5864-dollar-threshold #4860

Conversation

cyprain-okeke
Copy link
Contributor

@cyprain-okeke cyprain-okeke commented Oct 7, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11505
https://bitwarden.atlassian.net/browse/PM-13276

📔 Objective

Delete the feature flag PM-5864-dollar-threshold

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Oct 7, 2024

LaunchDarkly flag references

❌ 1 flag removed

Name Key Aliases found Info
Aggregated invoices for auto-scaling customers PM-5864-dollar-threshold ✅ all references removed

@cyprain-okeke cyprain-okeke requested review from a team and removed request for cturnbull-bitwarden October 7, 2024 12:08
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 41.57%. Comparing base (a1e4e47) to head (4618296).
Report is 83 commits behind head on main.

Files with missing lines Patch % Lines
...e/Services/Implementations/StripePaymentService.cs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4860   +/-   ##
=======================================
  Coverage   41.57%   41.57%           
=======================================
  Files        1357     1357           
  Lines       64056    64053    -3     
  Branches     5891     5891           
=======================================
  Hits        26631    26631           
+ Misses      36208    36205    -3     
  Partials     1217     1217           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Logo
Checkmarx One – Scan Summary & Detailse9f395c4-dd57-4fa7-9905-d6709ca65b54

No New Or Fixed Issues Found

@cyprain-okeke cyprain-okeke merged commit df4f8df into main Nov 4, 2024
51 checks passed
@cyprain-okeke cyprain-okeke deleted the pm-11505-delete-the-feature-flag-pm-5864-dollar-threshold branch November 4, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants