-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-11525] Tax calculation shown to customers potentially incorrect #4874
[PM-11525] Tax calculation shown to customers potentially incorrect #4874
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4874 +/- ##
==========================================
- Coverage 41.66% 41.64% -0.02%
==========================================
Files 1360 1363 +3
Lines 63888 63950 +62
Branches 5862 5863 +1
==========================================
+ Hits 26620 26634 +14
- Misses 36061 36109 +48
Partials 1207 1207 ☔ View full report in Codecov by Sentry. |
New Issues
Fixed Issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Please attach the recording
@cyprain-okeke This is just the backend part though. Request
Response
For New York: Response
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just a few requests.
}, | ||
LineItems = new() | ||
{ | ||
new() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it gets more complex we need to calculate this with the product identifier from Stripe if we use different tax codes per product.
[Route("~/tax/calculate")] | ||
public async Task<IResult> CalculateAsync([FromBody] CalculateTaxRequestModel requestBody) | ||
{ | ||
var options = new Stripe.Tax.CalculationCreateOptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need to wait on this PR until we get some clarity, but Stripe charges a fee per request when calculating tax. The fee is variable, and it might already be included in our plan, but we need to make sure we understand this first before we merge this.
https://stripe.com/tax/pricing
https://support.stripe.com/questions/understanding-stripe-tax-pricing
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11525
📔 Objective
This value is calculated using our exiting TaxRate records that we store in our own database and are managed via the Bitwarden Admin Portal. However, after we transitioned to using Stripe Tax for automatic tax calculations, there’s a likelihood that this “Estimated tax” value will be incorrect because whatever value we have saved could be different from the value Stripe calculates on the fly for the same zip code.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes