[deps] Auth: Update bootstrap to v5 [SECURITY] #4881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4881 +/- ##
=======================================
Coverage 42.66% 42.66%
=======================================
Files 1411 1411
Lines 65087 65087
Branches 5959 5959
=======================================
Hits 27772 27772
Misses 36075 36075
Partials 1240 1240 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
We do not use the carrousel component, so this security finding does not affect us directly. We do still wish to update to Version 5. But the lift to update the UI is larger and is impacting other flows. |
renovate
bot
force-pushed
the
renovate/npm-bootstrap-vulnerability
branch
from
b710e41 to
e81cb7f
Compare
renovate
bot
force-pushed
the
renovate/npm-bootstrap-vulnerability
branch
from
e81cb7f to
19cd403
Compare
bitwarden-bot
changed the title
|
Internal tracking:
|
renovate
bot
changed the title
|
I agree with @ike-kottlowski, updating all the UI is quite an effort. I ran a build from this branch locally, and all the CSS styles were broken. |
… existing theme colors
r-tome
reviewed
Nov 14, 2024
| @@ -49,3 +53,11 @@ h3 { | |||
| .form-check-input { | |||
| margin-top: .45rem; | |||
| } | |||
|
|
|||
| a { | |||
There was a problem hiding this comment.
Bootstrap 5 automatically adds an underline to hyperlinks. This change removes the underline to match the Bootstrap 4 style.
r-tome
requested review from
ike-kottlowski,
eliykat,
cturnbull-bitwarden and
withinfocus
@withinfocus I needed to adjust the appearance of hyperlinks, so I took the opportunity to upgrade Bootstrap to the latest version |
eliykat
previously approved these changes
Nov 15, 2024
ike-kottlowski
previously approved these changes
Nov 15, 2024
# Conflicts: # src/Admin/AdminConsole/Views/Providers/Edit.cshtml
r-tome
dismissed stale reviews from ike-kottlowski, eliykat, and withinfocus
via
74302b7
withinfocus
approved these changes
Nov 18, 2024
ike-kottlowski
approved these changes
Nov 18, 2024
r-tome
requested review from
eliykat and
a team
and removed request for
cturnbull-bitwarden
eliykat
approved these changes
Nov 19, 2024
jonashendrickx
approved these changes
Nov 19, 2024
cyprain-okeke
approved these changes
Nov 19, 2024
vgrassia
pushed a commit
to vgrassia/server
that referenced
this pull request
Nov 21, 2024
* [deps] Auth: Update bootstrap to v5 [SECURITY] * Update bootstrap and import dependencies in site.scss * Update site.scss to include the theme color 'dark' * Refactor site.scss to merge the 'primary-accent' theme color into the existing theme colors * Update bootstrap classes for v5 * Refactor form layout in Index.cshtml and AddExistingOrganization.cshtml * Revert change to the shield icon in the navbar * Fix organization form select inputs * Fixed search input sizes * Fix elements in Providers and Users search * More bootstrap migration * Revert change to tax rate delete button * Add missing label classes in Users/Edit.cshtml * More component migrations * Refactor form classes and labels in CreateMsp.cshtml and CreateReseller.cshtml * Update package dependencies in Sso * Revert changes to Providers/Edit.cshtml * Refactor CreateMultiOrganizationEnterprise.cshtml and Providers/Edit.cshtml for bootstrap 5 * Refactor webpack.config.js to use @popperjs/core instead of popper.js * Remove popperjs package dependency * Restore Bootstrap 4 link styling behavior - Remove default text decoration - Add underline only on hover * Update Bootstrap to version 5.3.3 * Update deprecated text color classes from 'text-muted' to 'text-body-secondary' across various views * Refactor provider edit view for bootstrap 5 * Remove underline in Add/Create organization links in provider page --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Rui Tome <[email protected]> Co-authored-by: Rui Tomé <[email protected]>
vgrassia
pushed a commit
to vgrassia/server
that referenced
this pull request
Nov 21, 2024
* [deps] Auth: Update bootstrap to v5 [SECURITY] * Update bootstrap and import dependencies in site.scss * Update site.scss to include the theme color 'dark' * Refactor site.scss to merge the 'primary-accent' theme color into the existing theme colors * Update bootstrap classes for v5 * Refactor form layout in Index.cshtml and AddExistingOrganization.cshtml * Revert change to the shield icon in the navbar * Fix organization form select inputs * Fixed search input sizes * Fix elements in Providers and Users search * More bootstrap migration * Revert change to tax rate delete button * Add missing label classes in Users/Edit.cshtml * More component migrations * Refactor form classes and labels in CreateMsp.cshtml and CreateReseller.cshtml * Update package dependencies in Sso * Revert changes to Providers/Edit.cshtml * Refactor CreateMultiOrganizationEnterprise.cshtml and Providers/Edit.cshtml for bootstrap 5 * Refactor webpack.config.js to use @popperjs/core instead of popper.js * Remove popperjs package dependency * Restore Bootstrap 4 link styling behavior - Remove default text decoration - Add underline only on hover * Update Bootstrap to version 5.3.3 * Update deprecated text color classes from 'text-muted' to 'text-body-secondary' across various views * Refactor provider edit view for bootstrap 5 * Remove underline in Add/Create organization links in provider page --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Rui Tome <[email protected]> Co-authored-by: Rui Tomé <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
4.6.2->5.0.0GitHub Vulnerability Alerts
CVE-2024-6531
A vulnerability has been identified in Bootstrap that exposes users to Cross-Site Scripting (XSS) attacks. The issue is present in the carousel component, where the data-slide and data-slide-to attributes can be exploited through the href attribute of an tag due to inadequate sanitization. This vulnerability could potentially enable attackers to execute arbitrary JavaScript within the victim's browser.
Release Notes
twbs/bootstrap (bootstrap)
v5.0.0Compare Source
Highlights
#32155: Updated
make-col()mixin to generate equal columns when no size is specified#32763: Added new
color-scheme()mixin#33389: Dropdown menus now have option become clickable
#33453: Added new docs footer
#33548: Offcanvas header components are now vertically aligned
#33549: Added offcanvas-top modifier
#33634: Added support for
.dropdown-items wrapped in<li>s#33626: Fix v5 regressions in tab dropdown functionality
🚀 Features
color-schememixin🎨 CSS
color-schememixin.nav-linkcolor consistent when using buttons:read-onlycss selector instead[readonly]for consistencyborder-topon Firefox☕️ JavaScript
hidemethod of dropdownisDisabledutil on dropdownnoopfunctionselectMenuItemmethod private.dropdown-itemwrapped in<li>tagsaltBoundaryoption📖 Docs
rel=noopenerattributeboundaryoptionboundaryoptionboundaryoption descriptionExamples
🌎 Accessibility
🏭 Tests
data-bs-backdrop="static"from modal tests🧰 Misc
📦 Dependencies
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.