[PM-12758] Add managed status to OrganizationUserDetailsResponseModel and OrganizationUserUserDetailsResponse #4918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gement status of organization users in details endpoint
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4918 +/- ##
=======================================
Coverage ? 42.33%
=======================================
Files ? 1384
Lines ? 64582
Branches ? 5934
=======================================
Hits ? 27342
Misses ? 36009
Partials ? 1231 ☔ View full report in Codecov by Sentry. |
…gement status of an individual user in details endpoint
r-tome
changed the title
|
Fixed Issues
|
eliykat
requested changes
Oct 23, 2024
src/Api/AdminConsole/Controllers/OrganizationUsersController.cs
Outdated
Show resolved
Hide resolved
test/Api.Test/AdminConsole/Controllers/OrganizationUsersControllerTests.cs
Outdated
Show resolved
Hide resolved
src/Api/AdminConsole/Models/Response/Organizations/OrganizationUserResponseModel.cs
Outdated
Show resolved
Hide resolved
eliykat
reviewed
Oct 23, 2024
src/Api/AdminConsole/Controllers/OrganizationUsersController.cs
Outdated
Show resolved
Hide resolved
…hod in OrganizationUserRepository
…tailsByIdWithCollectionsAsync
…ization is set accordingly
eliykat
approved these changes
Oct 23, 2024
…onuseruserdetailsresponse
r-tome
deleted the
ac/pm-12758/add-managed-status-to-organizationuseruserdetailsresponse
branch
cyprain-okeke
pushed a commit
that referenced
this pull request
Oct 30, 2024
… and OrganizationUserUserDetailsResponse (#4918) * Refactor OrganizationUsersController.Get to include organization management status of organization users in details endpoint * Refactor OrganizationUsersController.Get to include organization management status of an individual user in details endpoint * Remove redundant .ToDictionary() * Simpify the property xmldoc * Name tuple variables in OrganizationUsersController.Get * Name returned tuple objects in GetDetailsByIdWithCollectionsAsync method in OrganizationUserRepository * Refactor MembersController.Get to destructure tuple returned by GetDetailsByIdWithCollectionsAsync * Add test for OrganizationUsersController.Get to assert ManagedByOrganization is set accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-12758
📔 Objective
Add the
ManagedByOrganizationboolean property toOrganizationUserDetailsResponseModelandOrganizationUserUserDetailsResponseModel. This property indicates whether a user is managed by an organization, enabling certain actions in the admin console that are exclusive to managed users (e.g., deleting an account).⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes