-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-13362] Add private key regeneration endpoint #4929
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate-key-regen-endpoint
…ate-key-regen-endpoint
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4929 +/- ##
==========================================
+ Coverage 43.00% 43.17% +0.17%
==========================================
Files 1447 1451 +4
Lines 66164 66239 +75
Branches 6062 6070 +8
==========================================
+ Hits 28455 28601 +146
+ Misses 36427 36352 -75
- Partials 1282 1286 +4 ☔ View full report in Codecov by Sentry. |
New Issues
Fixed Issues
|
mzieniukbw
requested changes
Oct 25, 2024
src/Api/KeyManagement/Models/Requests/KeyRegenerationRequestModel.cs
Outdated
Show resolved
Hide resolved
test/Api.IntegrationTest/KeyManagement/Controllers/AccountsKeyManagementControllerTests.cs
Outdated
Show resolved
Hide resolved
test/Api.Test/KeyManagement/Controllers/AccountsKeyManagementControllerTests.cs
Outdated
Show resolved
Hide resolved
test/Core.Test/KeyManagement/Commands/RegenerateUserAsymmetricKeysCommandTests.cs
Show resolved
Hide resolved
mzieniukbw
previously approved these changes
Oct 25, 2024
Thomas-Avery
dismissed
mzieniukbw’s stale review
November 21, 2024 21:09
The base branch was changed.
mzieniukbw
previously approved these changes
Nov 26, 2024
mzieniukbw
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13362
📔 Objective
The purpose of this PR is to add an endpoint to enable private key regeneration for the clients on login and unlock.
This is feature will be behind a feature flag.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes