Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13362] Add private key regeneration endpoint #4929

Merged
merged 28 commits into from
Dec 16, 2024

Conversation

Thomas-Avery
Copy link
Contributor

@Thomas-Avery Thomas-Avery commented Oct 22, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13362

📔 Objective

The purpose of this PR is to add an endpoint to enable private key regeneration for the clients on login and unlock.
This is feature will be behind a feature flag.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Thomas-Avery Thomas-Avery self-assigned this Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 94.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 43.17%. Comparing base (d88a103) to head (2927a26).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nt/Commands/RegenerateUserAsymmetricKeysCommand.cs 88.88% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4929      +/-   ##
==========================================
+ Coverage   43.00%   43.17%   +0.17%     
==========================================
  Files        1447     1451       +4     
  Lines       66164    66239      +75     
  Branches     6062     6070       +8     
==========================================
+ Hits        28455    28601     +146     
+ Misses      36427    36352      -75     
- Partials     1282     1286       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 22, 2024

Logo
Checkmarx One – Scan Summary & Detailsa6ed0368-2fdd-4a91-ab8a-2a0d41115d0e

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 967 Attack Vector
MEDIUM CSRF /src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 37 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 967 Attack Vector
LOW Missing_CSP_Header /src/Core/MailTemplates/Handlebars/AdminConsole/DomainClaimedByOrganization.html.hbs: 5 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 70
MEDIUM CSRF /src/Billing/Controllers/RecoveryController.cs: 38
MEDIUM CSRF /src/Billing/Controllers/StripeController.cs: 164
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 91
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 470

@Thomas-Avery Thomas-Avery marked this pull request as ready for review October 24, 2024 19:17
@Thomas-Avery Thomas-Avery requested a review from a team as a code owner October 24, 2024 19:17
mzieniukbw
mzieniukbw previously approved these changes Oct 25, 2024
Base automatically changed from km/pm-13706/private-key-regen-db to main November 21, 2024 21:09
@Thomas-Avery Thomas-Avery dismissed mzieniukbw’s stale review November 21, 2024 21:09

The base branch was changed.

@Thomas-Avery Thomas-Avery requested a review from a team as a code owner November 21, 2024 21:09
@Thomas-Avery Thomas-Avery removed the request for review from a team November 21, 2024 21:55
mzieniukbw
mzieniukbw previously approved these changes Nov 26, 2024
@Thomas-Avery Thomas-Avery merged commit 7637cbe into main Dec 16, 2024
52 checks passed
@Thomas-Avery Thomas-Avery deleted the km/pm-13362/private-key-regen-endpoint branch December 16, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants