-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-13790] Remove RefactorOrganizationUserApi feature flag #4931
Merged
eliykat
merged 2 commits into
main
from
ac/pm-13790/remove-h1-implement-new-mini-details-organization-user-endpoint-feature-flag
Oct 25, 2024
Merged
[PM-13790] Remove RefactorOrganizationUserApi feature flag #4931
eliykat
merged 2 commits into
main
from
ac/pm-13790/remove-h1-implement-new-mini-details-organization-user-endpoint-feature-flag
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaunchDarkly flag references❌ 1 flag removed
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4931 +/- ##
==========================================
- Coverage 42.29% 42.27% -0.02%
==========================================
Files 1384 1384
Lines 64528 64514 -14
Branches 5930 5928 -2
==========================================
- Hits 27289 27275 -14
Misses 36010 36010
Partials 1229 1229 ☔ View full report in Codecov by Sentry. |
Fixed Issues
|
BTreston
approved these changes
Oct 23, 2024
…ails-organization-user-endpoint-feature-flag
Holding this one until |
cyprain-okeke
pushed a commit
that referenced
this pull request
Oct 30, 2024
Co-authored-by: MtnBurrit0 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13790
📔 Objective
Delete the
Pm3478RefactorOrganizationUserApi
feature flag. It has been turned on in production and is no longer required.It is only consumed by the web client which is always updated in step with
server
. We don't need to persist it for the 3 month support window.Clients PR: bitwarden/clients#11662
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes