Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13790] Remove RefactorOrganizationUserApi feature flag #4931

Conversation

eliykat
Copy link
Member

@eliykat eliykat commented Oct 23, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13790

📔 Objective

Delete the Pm3478RefactorOrganizationUserApi feature flag. It has been turned on in production and is no longer required.

It is only consumed by the web client which is always updated in step with server. We don't need to persist it for the 3 month support window.

Clients PR: bitwarden/clients#11662

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@eliykat eliykat requested a review from a team as a code owner October 23, 2024 01:05
@eliykat eliykat requested a review from BTreston October 23, 2024 01:05
Copy link
Contributor

LaunchDarkly flag references

❌ 1 flag removed

Name Key Aliases found Info
[H1] Implement new mini-details Organization User endpoint pm-3478-refactor-organizationuser-api ✅ all references removed

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.27%. Comparing base (a952d10) to head (31e07db).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4931      +/-   ##
==========================================
- Coverage   42.29%   42.27%   -0.02%     
==========================================
  Files        1384     1384              
  Lines       64528    64514      -14     
  Branches     5930     5928       -2     
==========================================
- Hits        27289    27275      -14     
  Misses      36010    36010              
  Partials     1229     1229              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 23, 2024

Logo
Checkmarx One – Scan Summary & Detailse5024baa-e912-4ebc-8de5-716579449bf6

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Admin/AdminConsole/Controllers/ProvidersController.cs: 427
MEDIUM CSRF /src/Admin/AdminConsole/Controllers/ProvidersController.cs: 352

…ails-organization-user-endpoint-feature-flag
@eliykat eliykat added the hold Hold this PR or item until later; DO NOT MERGE label Oct 23, 2024
@eliykat
Copy link
Member Author

eliykat commented Oct 23, 2024

Holding this one until clients is also approved.

@eliykat eliykat removed the hold Hold this PR or item until later; DO NOT MERGE label Oct 25, 2024
@eliykat eliykat merged commit 6272e84 into main Oct 25, 2024
56 of 58 checks passed
@eliykat eliykat deleted the ac/pm-13790/remove-h1-implement-new-mini-details-organization-user-endpoint-feature-flag branch October 25, 2024 00:17
cyprain-okeke pushed a commit that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants