-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-13451] Update subscription setup process to support MOE providers #4937
[PM-13451] Update subscription setup process to support MOE providers #4937
Conversation
…ation enterprises
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4937 +/- ##
=======================================
Coverage ? 42.30%
=======================================
Files ? 1384
Lines ? 64553
Branches ? 5933
=======================================
Hits ? 27308
Misses ? 36017
Partials ? 1228 ☔ View full report in Codecov by Sentry. |
New Issues
Fixed Issues
|
throw new BillingException(); | ||
subscriptionItemOptionsList.Add(new SubscriptionItemOptions | ||
{ | ||
Price = plan.PasswordManager.StripeProviderPortalSeatPlanId, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not defined for the Enterprise annual plan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13451
📔 Objective
Generalized
SetupSubscriptionAsync
which is called inPOST /providers{providerId:guid}/setup
to support multi-organization enterprises. We already know we have to configure every provider plan, and can just iterate through all of them.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes