-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-13014] - Add CanToggleStatus property to PolicyRepsonseModel based on Policy Validators #4940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Added mappings wrapped in feature flag.
… same type of policy validator into its DI.
New Issues
Fixed Issues
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4940 +/- ##
==========================================
+ Coverage 42.57% 42.60% +0.02%
==========================================
Files 1387 1389 +2
Lines 64653 64678 +25
Branches 5933 5937 +4
==========================================
+ Hits 27528 27553 +25
+ Misses 35903 35901 -2
- Partials 1222 1224 +2 ☔ View full report in Codecov by Sentry. |
eliykat
requested changes
Oct 25, 2024
...Core/AdminConsole/OrganizationFeatures/Policies/PolicyValidators/SingleOrgPolicyValidator.cs
Outdated
Show resolved
Hide resolved
…om List endpoint. Added new details model for single policy response. Validator now returns after first error.
# Conflicts: # src/Api/AdminConsole/Controllers/PoliciesController.cs
eliykat
requested changes
Nov 1, 2024
src/Api/AdminConsole/Models/Response/Helpers/PolicyDetailResponses.cs
Outdated
Show resolved
Hide resolved
src/Core/AdminConsole/Models/Api/Response/PolicyDetailResponseModel.cs
Outdated
Show resolved
Hide resolved
eliykat
approved these changes
Nov 3, 2024
Jingo88
approved these changes
Nov 6, 2024
ike-kottlowski
approved these changes
Nov 8, 2024
cyprain-okeke
pushed a commit
that referenced
this pull request
Nov 12, 2024
…d on Policy Validators (#4940) * Adding CanToggleState to PoliciesControllers (api/public) endpoints. Added mappings wrapped in feature flag. * Updated logic for determining CanToggle. Removed setting of toggle from List endpoint. Added new details model for single policy response. Validator now returns after first error.
vgrassia
pushed a commit
to vgrassia/server
that referenced
this pull request
Nov 21, 2024
…d on Policy Validators (bitwarden#4940) * Adding CanToggleState to PoliciesControllers (api/public) endpoints. Added mappings wrapped in feature flag. * Updated logic for determining CanToggle. Removed setting of toggle from List endpoint. Added new details model for single policy response. Validator now returns after first error.
vgrassia
pushed a commit
to vgrassia/server
that referenced
this pull request
Nov 21, 2024
…d on Policy Validators (bitwarden#4940) * Adding CanToggleState to PoliciesControllers (api/public) endpoints. Added mappings wrapped in feature flag. * Updated logic for determining CanToggle. Removed setting of toggle from List endpoint. Added new details model for single policy response. Validator now returns after first error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-13014
📔 Objective
This will add a
CanToggleStatus
flag to thePolicyResponseModel
to inform clients on whether or not they will be allowed to change the status of the policy (enable/disable). This is using the newPolicyValidator#ValidateAsync
methods to determine if it can be changed. This is limited toSingle Org Policy
for now.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes