Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRE-385 - Provisioning license #4961

Closed
wants to merge 3 commits into from
Closed

BRE-385 - Provisioning license #4961

wants to merge 3 commits into from

Conversation

mimartin12
Copy link
Contributor

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@mimartin12 mimartin12 marked this pull request as ready for review October 31, 2024 14:38
@mimartin12 mimartin12 requested a review from a team as a code owner October 31, 2024 14:38
@mimartin12 mimartin12 requested a review from rr-bw October 31, 2024 14:38
@mimartin12 mimartin12 marked this pull request as draft October 31, 2024 14:39
@bitwarden-devops-bot
Copy link
Contributor

@bitwarden-devops-bot
Copy link
Contributor

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.53%. Comparing base (dae493d) to head (5fe79dc).
Report is 134 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4961   +/-   ##
=======================================
  Coverage   42.53%   42.53%           
=======================================
  Files        1391     1391           
  Lines       64792    64792           
  Branches     5945     5945           
=======================================
  Hits        27561    27561           
  Misses      36008    36008           
  Partials     1223     1223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwarden-devops-bot
Copy link
Contributor

1 similar comment
@bitwarden-devops-bot
Copy link
Contributor

@bitwarden-devops-bot
Copy link
Contributor

@mimartin12 mimartin12 closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants