Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-10323] Remove user verification from organization user deletion methods #4965

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

r-tome
Copy link
Contributor

@r-tome r-tome commented Nov 1, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10323

📔 Objective

The organization user deletion endpoints were initially designed with user verification in mind. However, after discussing with the Product team, we concluded that verification is not necessary.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.55%. Comparing base (96862b9) to head (9fd8726).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4965      +/-   ##
==========================================
- Coverage   42.56%   42.55%   -0.01%     
==========================================
  Files        1389     1388       -1     
  Lines       64726    64717       -9     
  Branches     5940     5938       -2     
==========================================
- Hits        27548    27539       -9     
  Misses      35959    35959              
  Partials     1219     1219              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-tome r-tome marked this pull request as ready for review November 1, 2024 16:39
@r-tome r-tome requested a review from a team as a code owner November 1, 2024 16:39
@r-tome r-tome requested a review from jrmccannon November 1, 2024 16:39
@r-tome r-tome merged commit 60672bb into main Nov 4, 2024
52 checks passed
@r-tome r-tome deleted the ac/pm-10323/add-delete-option-to-managed-member branch November 4, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants