Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14443] Cannot view pending MOE provider page #4970

Conversation

jonashendrickx
Copy link
Member

@jonashendrickx jonashendrickx commented Nov 4, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14443

📔 Objective

An InvalidOperationException gets thrown when viewing a Multi-organization enterprise provider that is in a Pending status.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jonashendrickx jonashendrickx requested review from a team as code owners November 4, 2024 08:11
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 42.55%. Comparing base (35b0f61) to head (fcc793d).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/Admin/AdminConsole/Models/ProviderEditModel.cs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4970      +/-   ##
==========================================
- Coverage   42.55%   42.55%   -0.01%     
==========================================
  Files        1389     1389              
  Lines       64729    64726       -3     
  Branches     5940     5943       +3     
==========================================
- Hits        27548    27545       -3     
  Misses      35962    35962              
  Partials     1219     1219              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonashendrickx jonashendrickx merged commit d53d9c0 into main Nov 4, 2024
52 checks passed
@jonashendrickx jonashendrickx deleted the PM-14443-Admin-Pending-MOE-throws-invalid-operation-exception-on-viewing-the-edit-provider-page branch November 4, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants