-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-13763 Move ResetPasswordEnrolled to response model #4983
PM-13763 Move ResetPasswordEnrolled to response model #4983
Conversation
…skov Substitution Principle. Ensures request models inherit only relevant properties.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4983 +/- ##
==========================================
- Coverage 42.54% 42.53% -0.02%
==========================================
Files 1389 1391 +2
Lines 64745 64824 +79
Branches 5943 5950 +7
==========================================
+ Hits 27548 27571 +23
- Misses 35975 36028 +53
- Partials 1222 1225 +3 ☔ View full report in Codecov by Sentry. |
New Issues
Fixed Issues
|
public class MemberResponseModelTests | ||
{ | ||
[Fact] | ||
public void ResetPasswordEnrolled_ShouldBeTrue_WhenUserHasResetPasswordKey() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was following patterns that I’ve seen in the codebase. If anything doesn’t meet standards, please feel free to leave comments, documentation, or suggestions. I’m happy to receive feedback and learn! 😄
to adhere to Liskov Substitution Principle. Ensures request models inherit only relevant properties.
to adhere to Liskov Substitution Principle. Ensures request models inherit only relevant properties.
to adhere to Liskov Substitution Principle. Ensures request models inherit only relevant properties.
Move ResetPasswordEnrolled to the response model to adhere to the Liskov Substitution Principle. Ensures request models inherit only relevant properties.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13763
📔 Objective
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes