-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-11409] prevent managed user from leaving managing organization #4995
Merged
BTreston
merged 3 commits into
main
from
ac/pm-11409-prevent-managed-user-from-leaving-organization
Nov 7, 2024
Merged
[PM-11409] prevent managed user from leaving managing organization #4995
BTreston
merged 3 commits into
main
from
ac/pm-11409-prevent-managed-user-from-leaving-organization
Nov 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmccannon
requested changes
Nov 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4995 +/- ##
=======================================
Coverage 42.53% 42.53%
=======================================
Files 1391 1391
Lines 64816 64825 +9
Branches 5949 5950 +1
=======================================
+ Hits 27567 27571 +4
- Misses 36024 36029 +5
Partials 1225 1225 ☔ View full report in Codecov by Sentry. |
jrmccannon
approved these changes
Nov 7, 2024
New Issues
Fixed Issues
|
BTreston
deleted the
ac/pm-11409-prevent-managed-user-from-leaving-organization
branch
November 7, 2024 19:10
cyprain-okeke
pushed a commit
that referenced
this pull request
Nov 12, 2024
…4995) * prevent managed user from leaving managing organization * fix org check to be specific to single org * simplify logic
vgrassia
pushed a commit
to vgrassia/server
that referenced
this pull request
Nov 21, 2024
…itwarden#4995) * prevent managed user from leaving managing organization * fix org check to be specific to single org * simplify logic
vgrassia
pushed a commit
to vgrassia/server
that referenced
this pull request
Nov 21, 2024
…itwarden#4995) * prevent managed user from leaving managing organization * fix org check to be specific to single org * simplify logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11409
📔 Objective
This PR implements a server side check to ensure that users that are managed by the org they may be attempting to leave will throw
BadRequestException
.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes