Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13783] Battle harden ProviderType enum expansion #5004

Merged

Conversation

jonashendrickx
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13783

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jonashendrickx jonashendrickx requested a review from a team as a code owner November 8, 2024 07:54
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 42.59%. Comparing base (702a81b) to head (d92a1f3).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/Core/Context/CurrentContext.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5004   +/-   ##
=======================================
  Coverage   42.58%   42.59%           
=======================================
  Files        1406     1406           
  Lines       65074    65075    +1     
  Branches     5962     5962           
=======================================
+ Hits        27715    27716    +1     
  Misses      36131    36131           
  Partials     1228     1228           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Logo
Checkmarx One – Scan Summary & Details4daf6251-2429-444a-96c7-66892f190aca

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 68
MEDIUM CSRF /src/Api/Auth/Controllers/EmergencyAccessController.cs: 102
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 89
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 159
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 42
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 61
MEDIUM CSRF /src/Api/Auth/Controllers/EmergencyAccessController.cs: 159
MEDIUM CSRF /src/Api/Auth/Controllers/EmergencyAccessController.cs: 102
LOW Log_Forging /src/Api/Auth/Controllers/EmergencyAccessController.cs: 102

@jonashendrickx jonashendrickx merged commit 6f7cdcf into main Nov 13, 2024
52 checks passed
@jonashendrickx jonashendrickx deleted the PM-13783-API-Battle-harden-the-ProviderType-enum-expansion branch November 13, 2024 14:01
vgrassia pushed a commit to vgrassia/server that referenced this pull request Nov 21, 2024
vgrassia pushed a commit to vgrassia/server that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants