Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-10873] Updated errors thrown when creating organization on selfhost to be more specific #5007

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

cturnbull-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10873

📔 Objective

Updated the self-hosted server's validation when uploading a new license. Updates are to ensure that the plan specified on the license exists, is not disabled, and also that the license type is accurate.

📸 Screenshots

image
image
image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cturnbull-bitwarden cturnbull-bitwarden requested a review from a team as a code owner November 8, 2024 16:08
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 42.92%. Comparing base (c591997) to head (2f683b9).
Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
...le/Services/Implementations/OrganizationService.cs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5007      +/-   ##
==========================================
- Coverage   42.92%   42.92%   -0.01%     
==========================================
  Files        1433     1433              
  Lines       65653    65660       +7     
  Branches     6020     6021       +1     
==========================================
  Hits        28184    28184              
- Misses      36204    36211       +7     
  Partials     1265     1265              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Logo
Checkmarx One – Scan Summary & Details3ba5b7ec-eade-45c1-9117-5a464038c1cf

No New Or Fixed Issues Found

vincentsalucci
vincentsalucci previously approved these changes Nov 8, 2024
Copy link
Member

@vincentsalucci vincentsalucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ Would really love to see some unit tests around the newly added error paths.

SAST scan failed

Looks good otherwise!

jonashendrickx
jonashendrickx previously approved these changes Nov 11, 2024
r-tome
r-tome previously approved these changes Nov 19, 2024
# Conflicts:
#	src/Core/AdminConsole/Services/Implementations/OrganizationService.cs
@cturnbull-bitwarden cturnbull-bitwarden merged commit 9321515 into main Dec 16, 2024
52 checks passed
@cturnbull-bitwarden cturnbull-bitwarden deleted the billing/PM-10873/license-error-too-generic branch December 16, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants