-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-10873] Updated errors thrown when creating organization on selfhost to be more specific #5007
[PM-10873] Updated errors thrown when creating organization on selfhost to be more specific #5007
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5007 +/- ##
==========================================
- Coverage 42.92% 42.92% -0.01%
==========================================
Files 1433 1433
Lines 65653 65660 +7
Branches 6020 6021 +1
==========================================
Hits 28184 28184
- Misses 36204 36211 +7
Partials 1265 1265 ☔ View full report in Codecov by Sentry. |
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⛏️ Would really love to see some unit tests around the newly added error paths.
SAST scan failed
Looks good otherwise!
# Conflicts: # src/Core/AdminConsole/Services/Implementations/OrganizationService.cs
2f683b9
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-10873
📔 Objective
Updated the self-hosted server's validation when uploading a new license. Updates are to ensure that the plan specified on the license exists, is not disabled, and also that the license type is accurate.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes