Pm 14861 vault items fail to load #5031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5031 +/- ##
==========================================
+ Coverage 42.58% 42.67% +0.08%
==========================================
Files 1406 1406
Lines 65074 65099 +25
Branches 5962 5970 +8
==========================================
+ Hits 27715 27781 +66
+ Misses 36131 36073 -58
- Partials 1228 1245 +17 ☔ View full report in Codecov by Sentry. |
|
New Issues
Fixed Issues
|
cturnbull-bitwarden
approved these changes
Nov 12, 2024
vgrassia
pushed a commit
to vgrassia/server
that referenced
this pull request
Nov 21, 2024
* Resolve vault items fail to load * Add hasSubscription to metadata * Remove unused property * Fix the failing unit test
vgrassia
pushed a commit
to vgrassia/server
that referenced
this pull request
Nov 21, 2024
* Resolve vault items fail to load * Add hasSubscription to metadata * Remove unused property * Fix the failing unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14860
📔 Objective
Tested using MSP client org. I sent an invite to a new Owner role in Client Org and after I confirmed the Owner, it got kicked out of the app and cannot log in after that.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes