Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15069] Updated customer metadata when updating to use bank account #5050

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

cturnbull-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15069

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cturnbull-bitwarden cturnbull-bitwarden requested a review from a team as a code owner November 19, 2024 20:07
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.06%. Comparing base (5166085) to head (e83d7a3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5050   +/-   ##
=======================================
  Coverage   43.06%   43.06%           
=======================================
  Files        1412     1412           
  Lines       64775    64776    +1     
  Branches     5920     5920           
=======================================
+ Hits        27894    27895    +1     
  Misses      35649    35649           
  Partials     1232     1232           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsae4dbdf3-bb59-4447-873b-688854ccf48b

No New Or Fixed Issues Found

@bitwarden-devops-bot
Copy link
Contributor

@cturnbull-bitwarden cturnbull-bitwarden merged commit 77cde50 into main Nov 20, 2024
52 of 53 checks passed
@cturnbull-bitwarden cturnbull-bitwarden deleted the billing/PM-15069/btcustomeridold branch November 20, 2024 14:32
vgrassia pushed a commit to vgrassia/server that referenced this pull request Nov 21, 2024
vgrassia pushed a commit to vgrassia/server that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants