[PM-10564] Push notification updates to other clients #5057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a notification is updated, marked as read or deleted, a push notification is sent with updated push type event. The push notification includes the ReadDate and DeletedDate fields.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## km/pm-10600-full-notification-content #5057 +/- ##
=========================================================================
+ Coverage 43.60% 43.63% +0.02%
=========================================================================
Files 1456 1456
Lines 66610 66723 +113
Branches 6094 6098 +4
=========================================================================
+ Hits 29047 29112 +65
- Misses 36268 36316 +48
Partials 1295 1295 ☔ View full report in Codecov by Sentry. |
…nt type. Any update to the Notification from user perspective should be treated as update. That includes NotificationStatus, which when created would be displayed as update to the notification. Hence, push notification should be update type.
NotificationStatus not needed.
|
No New Or Fixed Issues Found |
src/Core/NotificationCenter/Commands/UpdateNotificationCommand.cs
Outdated
Show resolved
Hide resolved
|
Moving to draft for now. I will update the event types to be |
…ates Sync notification push type is now used for both Notification create and update. Renamed the event types to specifically mention the purpose of status for notification status updates.
Thomas-Avery
approved these changes
Nov 25, 2024
| @@ -25,7 +25,7 @@ public class AzureQueuePushNotificationServiceTests | |||
| [BitAutoData] | |||
| [NotificationCustomize] | |||
| [CurrentContextCustomize] | |||
| public async void PushSyncNotificationAsync_Notification_Sent( | |||
| public async Task PushSyncNotificationAsync_Notification_Sent( | |||
There was a problem hiding this comment.
👍 Nice job on updating these.
# Conflicts: # src/Core/Models/PushNotification.cs # src/Core/Services/IPushNotificationService.cs # src/Core/Services/NoopImplementations/NoopPushNotificationService.cs # test/Core.Test/NotificationCenter/Commands/CreateNotificationCommandTest.cs # test/Core.Test/NotificationHub/NotificationHubPushNotificationServiceTests.cs # test/Core.Test/Services/AzureQueuePushNotificationServiceTests.cs
mzieniukbw
changed the base branch from
km/pm-10600
to
km/pm-10600-full-notification-content
# Conflicts: # src/Core/Enums/PushType.cs # src/Core/NotificationHub/NotificationHubPushNotificationService.cs # src/Core/Services/IPushNotificationService.cs # src/Core/Services/Implementations/MultiServicePushNotificationService.cs # src/Core/Services/Implementations/NotificationsApiPushNotificationService.cs # src/Core/Services/Implementations/RelayPushNotificationService.cs # src/Core/Services/NoopImplementations/NoopPushNotificationService.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-10564
This is Part 3.
See Part 2: #5086
See Part 4: #5079
📔 Objective
When a notification is updated, marked as read or deleted, a push notification is sent with updated push type event. The push notification includes the ReadDate and DeletedDate fields.
Notes
SyncNotificationtoSyncNotificationCreatepush type event.SyncNotificationUpdatepush type event📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes