Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14377] Add PATCH complete endpoint #5100

Merged
merged 24 commits into from
Dec 13, 2024
Merged

[PM-14377] Add PATCH complete endpoint #5100

merged 24 commits into from
Dec 13, 2024

Conversation

gbubemismith
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14377

📔 Objective

Endpoint used by end-users to mark a SecurityTask as Complete. Endpoint needs to ensure the user has the necessary permissions to update the task.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@gbubemismith gbubemismith marked this pull request as ready for review December 2, 2024 20:30
@gbubemismith gbubemismith requested a review from a team as a code owner December 2, 2024 20:30
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 76.31579% with 9 lines in your changes missing coverage. Please review.

Project coverage is 42.94%. Comparing base (a3174cf) to head (ab0ef5a).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...rc/Api/Vault/Controllers/SecurityTaskController.cs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5100      +/-   ##
==========================================
+ Coverage   42.91%   42.94%   +0.03%     
==========================================
  Files        1444     1446       +2     
  Lines       66086    66123      +37     
  Branches     6056     6058       +2     
==========================================
+ Hits        28358    28394      +36     
- Misses      36446    36447       +1     
  Partials     1282     1282              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Logo
Checkmarx One – Scan Summary & Details91f5b48f-2ead-4e7b-a91b-d2ec5901d7b8

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Billing/Controllers/PayPalController.cs: 66 Attack Vector
LOW Missing_CSP_Header /src/Core/MailTemplates/Handlebars/AdminConsole/DomainClaimedByOrganization.html.hbs: 5 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 70
MEDIUM CSRF /src/Api/Controllers/LicensesController.cs: 44
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 106
MEDIUM CSRF /src/Billing/Controllers/RecoveryController.cs: 38
MEDIUM CSRF /src/Api/Billing/Controllers/OrganizationsController.cs: 52
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/OrganizationController.cs: 42
MEDIUM CSRF /src/Billing/Controllers/StripeController.cs: 164
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 238
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/OrganizationController.cs: 42
MEDIUM CSRF /src/Admin/AdminConsole/Controllers/OrganizationsController.cs: 372
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 91
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 46
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 65
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 533
LOW Log_Forging /src/Api/AdminConsole/Controllers/ProvidersController.cs: 72
LOW Log_Forging /src/Api/AdminConsole/Controllers/ProvidersController.cs: 72
LOW Log_Forging /src/Api/AdminConsole/Controllers/ProvidersController.cs: 72

shane-melton
shane-melton previously approved these changes Dec 11, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for adding tests!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Helpful!

Base automatically changed from vault/PM-14376 to main December 12, 2024 19:27
@gbubemismith gbubemismith dismissed shane-melton’s stale review December 12, 2024 19:27

The base branch was changed.

@gbubemismith gbubemismith requested a review from a team as a code owner December 12, 2024 19:27
@gbubemismith gbubemismith requested review from shane-melton and removed request for a team December 13, 2024 19:15
@gbubemismith gbubemismith merged commit 141a046 into main Dec 13, 2024
52 checks passed
@gbubemismith gbubemismith deleted the vault/PM-14377 branch December 13, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants