-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-14377] Add PATCH complete endpoint #5100
Conversation
Created user defined type to hold status Created migration file
modified script to check for users with edit rights
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5100 +/- ##
==========================================
+ Coverage 42.91% 42.94% +0.03%
==========================================
Files 1444 1446 +2
Lines 66086 66123 +37
Branches 6056 6058 +2
==========================================
+ Hits 28358 28394 +36
- Misses 36446 36447 +1
Partials 1282 1282 ☔ View full report in Codecov by Sentry. |
New Issues
Fixed Issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for adding tests!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Helpful!
The base branch was changed.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14377
📔 Objective
Endpoint used by end-users to mark a SecurityTask as Complete. Endpoint needs to ensure the user has the necessary permissions to update the task.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes